Conversation
jorgeazevedo
added
the
maintenance
Contributor
- Replace deprecated new URL() constructor with getClass.getResource() - Remove unused @nowarn annotation and classpathHandler
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Prism application runtime from Java 11 to Java 21, updating infrastructure configuration, simplifying classpath resource handling, and updating version management files.
Changes:
- Upgraded EC2 deployment infrastructure from Ubuntu 20.04 Focal with Java 11 to Ubuntu 22.04 Jammy with Java 21
- Simplified classpath resource loading by removing custom URLStreamHandler implementation
- Updated version management configuration to use Java 21 (Corretto)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cdk/lib/prism.ts | Updated imageRecipe to use arm64-jammy-java21-deploy-infrastructure for EC2 instances |
| app/agent/origin.scala | Simplified classpath resource loading by removing custom URLStreamHandler and using getClass.getResource() directly; removed unused imports |
| README.md | Updated documentation to specify Java 21 requirement |
| .tool-versions | Updated Java version from corretto-11.0.25.9.1 to corretto-21 |
| .java-version | Removed file (redundant with .tool-versions which is the primary asdf configuration) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Upgrades Java runtime from 11 to 21.
How has this change been tested?
sbt clean compile testcd cdk && npm testHave we considered potential risks?