Newsletter signup requests pass location (country) and location state#28681
Open
Newsletter signup requests pass location (country) and location state#28681
Conversation
added 2 commits
March 24, 2026 10:41
…nsent-signup and /consent-email IDAPI endpoints
…tter signup form as well
johnduffell
reviewed
Mar 24, 2026
johnduffell
reviewed
Mar 24, 2026
johnduffell
reviewed
Mar 24, 2026
added 2 commits
March 25, 2026 22:30
…on to get rid of duplication. Make the way we get the country code more readable
Contributor
AshCorr
reviewed
Mar 26, 2026
Comment on lines
+97
to
+100
| "privateFields" -> ( | ||
| "registrationLocation" -> registrationLocation, | ||
| "registrationLocationState" -> registrationLocationState, | ||
| ), |
Member
There was a problem hiding this comment.
Suggested change
| "privateFields" -> ( | |
| "registrationLocation" -> registrationLocation, | |
| "registrationLocationState" -> registrationLocationState, | |
| ), | |
| "registration-location" -> registrationLocation, | |
| "registration-location-state" -> registrationLocationState, |
I suggested privateFields because I thought this was going to be using the /guest endpoint, but I think we'll implement it slightly different for the newsletter signup endpoints!
…onsent-email IDAPI endpoints
…ove privateFields request body property/object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
The CRM teams for the different regions cannot personalise marketing based on region for users without a registration_location set.
Currently the US has a workaround in which these ‘regionless’ users are counted as US users if they have signed up for a US editorial newsletter but this could result in false positives and a poor CRM experience.
What does this change?
Pass location and location state (If in US or AUS) through to the /consent-signup and /consent-email IDAPI endpoints when a user signs up for a newsletter