Conversation
akinsola-guardian
added
the
dependencies
There was a problem hiding this comment.
Pull request overview
Updates the frontend’s dependency on @guardian/libs to v29.0.1, with corresponding lockfile updates, and modifies consent UUID extraction logic in boot.js for USNAT/AUS consent reporting to Ophan.
Changes:
- Bump
@guardian/libsfrom 26.1.0 to 29.0.1 inpackage.json. - Update
yarn.lockfor the new@guardian/libsversion (including updated transitive deps/peer expectations). - Adjust consent UUID selection logic/comments in
static/src/javascripts/boot.js(USNAT and AUS branches).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
package.json |
Updates declared dependency version for @guardian/libs. |
yarn.lock |
Locks @guardian/libs@29.0.1 and updated related dependency metadata. |
static/src/javascripts/boot.js |
Updates consent UUID lookup behavior (USNAT/AUS) and adds explanatory comments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
static/src/javascripts/boot.js
Outdated
| // Users who interacted with the CCPA banner before the migration to usnat will still have a ccpaUUID cookie. The usnatUUID cookie is set when the USNAT banner is interacted with. We need to check both cookies to ensure we have the correct consentUUID. | ||
| const consentUUID = |
There was a problem hiding this comment.
The newly added comment line uses tab indentation and is misaligned relative to surrounding code. It also appears to exceed typical max line length; please reformat to match the file’s indentation/style so linting/formatting stays consistent.
package.json
Outdated
| "@guardian/identity-auth": "6.0.1", | ||
| "@guardian/identity-auth-frontend": "8.1.0", | ||
| "@guardian/libs": "26.1.0", | ||
| "@guardian/libs": "29.0.1", |
There was a problem hiding this comment.
Bumping @guardian/libs to 29.0.1 updates its peer dependency expectations (in yarn.lock) to tslib: ^2.8.1 and typescript: ~5.9.3, but this repo still pins tslib@2.6.2 and typescript@5.3.3. Please either bump these to satisfy the new peer ranges or confirm (and document) that @guardian/libs@29.0.1 is compatible with the older versions to avoid runtime helper or type-check issues.
| "@guardian/libs": "29.0.1", | |
| "@guardian/libs": "28.0.0", |
akinsola-guardian
force-pushed
the
al/bump-gu-libs-29-0-0
branch
from
4791a57 to
5f6e238
Compare
What does this change?
Why?
Migrating Australian framework to GlobalCMP framework.