Convert the Affiliate Disclaimer component to server-side only #15201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Undoes the changes implemented here #15018 and then here #15074 - we don't need to rehydrate the various Affiliate Disclaimer components in the client and fire a custom Ophan Component Event in order to detect it is on the page, we can just add the
data-componentattribute to the server-side rendered element - on page load Ophan tracker-js will track any HTML elements on the page with thedata-componentattribute!I've therefore refactored these components back to being purely server-side as they're less complex and it means less
.jsto ship to & run in the browser.Why?
Less code to achieve what we want.