Skip to content

Conversation

@domlander
Copy link
Contributor

@domlander domlander commented Jan 21, 2026

What does this change?

Enable loops on Feature Card. If a Loop video is applied to a Feature Card it will now behave like a loop instead of a cinemagraph. It will have audio (if available), subtitles (if available) and play/pause is enabled.

Clicks:

  • The overlay area links through the card
  • The audio icon behaves as normal
  • Any other click pauses/unpause the video

Immersive feature cards aren't currently supported, but a screenshot is included to show where we are right now. The display on mobile doesn't look good, for instance. We'd like to improve this in a future PR before officially supporting it

Screenshots

Note that these videos aren't 4:5 and 5:3 respectively. They will look better when correctly cropped videos are used in Production!

Before After
before after
before2 after2

@domlander domlander self-assigned this Jan 21, 2026
@domlander domlander added run_chromatic Runs chromatic when label is applied fronts + curation maintenance Departmental tracking: maintenance work, not a fix or a feature labels Jan 21, 2026
@domlander domlander changed the title Loops on Feature Cards [WIP] Loops on Feature Cards Jan 21, 2026
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jan 21, 2026
@github-actions
Copy link

github-actions bot commented Jan 21, 2026

@domlander domlander force-pushed the doml/crop-tall-video branch from eea1927 to ea1a43e Compare January 22, 2026 11:06
Base automatically changed from doml/crop-tall-video to main January 22, 2026 13:59
@domlander domlander changed the title [WIP] Loops on Feature Cards Loops on Feature Cards Jan 22, 2026
@domlander domlander changed the base branch from main to doml/fix-video-aspect-ratio-mobile January 22, 2026 14:32
@domlander domlander changed the base branch from doml/fix-video-aspect-ratio-mobile to main January 22, 2026 14:33
@domlander domlander force-pushed the doml/feature-card-loops branch from 8758045 to 6d7a58e Compare January 22, 2026 14:39
@github-actions
Copy link

github-actions bot commented Jan 22, 2026

@domlander domlander added the run_chromatic Runs chromatic when label is applied label Jan 22, 2026
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jan 22, 2026
@domlander domlander force-pushed the doml/feature-card-loops branch 3 times, most recently from 5a2f271 to cf86298 Compare January 22, 2026 15:29
@domlander domlander added the run_chromatic Runs chromatic when label is applied label Jan 22, 2026
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jan 22, 2026
@domlander domlander marked this pull request as ready for review January 22, 2026 15:35
@github-actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@domlander domlander force-pushed the doml/feature-card-loops branch from cf86298 to 31288fa Compare January 22, 2026 16:18
@domlander domlander added the run_chromatic Runs chromatic when label is applied label Jan 22, 2026
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fronts + curation maintenance Departmental tracking: maintenance work, not a fix or a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants