Refactor banner component #15166
Open
Refactor banner component #15166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 15, 2026 11:11
…ion, and layout improvements - Add close button functionality with channel timestamp storage and custom event dispatch - Integrate tracking handlers for close, collapse, expand, and CTA clicks - Add isOpen state to control banner visibility - Reset selectedChoiceCard when choiceCards change - Initialize isCollapsed to false instead of using isCollapsableBanner - Create combined handlers that run both tracking and prop callbacks
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
juabara
added
feature
added 3 commits
January 20, 2026 16:28
…an/dotcom-rendering into jm/feat-refactor-banner-component
tomrf1
reviewed
Jan 21, 2026
|
|
||
| export interface CloseableBannerProps extends BannerProps { | ||
| onClose: () => void; | ||
| children?: React.ReactNode; |
…m hook Move banner state management and data transformation logic from Banner component into useDesignableBannerModel hook. Extract selector logic into separate bannerSelectors module for better separation of concerns.
Contributor
Author
Improvements in state management
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Motivation
Simplified the Banner v2 component architecture by consolidating all data, state, and actions into a single
bannerDataprop that flows through all child components. This makes the structure more straightforward, with each component responsible for its own rendering logic and visibility decisions. Removed thechildrenprop in favor of a fixed component hierarchy where all 11 child components are always rendered and decide internally whether to display based on thebannerDatathey receive.🔧 Key Changes
bannerDataprop✅ Verification
All existing functionality preserved (event tracking, state management, conditional rendering). No breaking changes to public API.