Add click tracking for the product carousel cards. #15164
+17
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
emma-imber
reviewed
Jan 21, 2026
| product.elementId | ||
| } | ||
| css={[subgridStyles, leftBorderStyles]} | ||
| data-component={`at-a-glance-carousel-card-${index}`} |
Contributor
There was a problem hiding this comment.
Do we want the data-component to be at-a-glance-carousel-card-0 for the first card as it is here? Or would it be more readable for non developers looking at the data for it to be at-a-glance-carousel-card-1?
Contributor
Author
There was a problem hiding this comment.
Ahh yea would be good to align with the stacked cards, are you doing index + 1 there?
Contributor
There was a problem hiding this comment.
Yep stacked cards is doing index + 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Include index of product in the Product Button click event in Carousel components by adding this attribute
data-component={at-a-glance-carousel-card-${index}}Why?
We want to understand the number of users interacting with the cards based on where they appear in the carousel. This PR provides the index within the click event component id.