Replace at a glance with scrollable carousel #15110
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleycampbell
changed the title
GHaberis
reviewed
Jan 15, 2026
GHaberis
reviewed
Jan 15, 2026
Contributor
oliverabrahams
left a comment
oliverabrahams
left a comment
There was a problem hiding this comment.
Left some comments, Very happy to chat through them.
charleycampbell
force-pushed
the
replace-at-a-glance
branch
from
25b2542 to
c8e84f7
Compare
…er the nav buttons - Increases the product threshold from 2 to 3 for the carosuel to render - Removes the at a glance which is added in Composer as we have it as part of the new rendered elements
- make carsouel an unordered list
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
| products.length >= 3; | ||
|
|
||
| const insertCarouselPlaceholder = (elements: FEElement[]): FEElement[] => { | ||
| if (!Array.isArray(elements) || elements.length === 0) return []; |
Contributor
There was a problem hiding this comment.
We shouldn't need this check here as it will return an empty array if it is empty and should always be an array think this relates to the TS issues you were having in the editor yday
Suggested change
| if (!Array.isArray(elements) || elements.length === 0) return []; |
| if (!inAtAGlanceSection) { | ||
| if (isAtAGlance(element)) { | ||
| inAtAGlanceSection = true; | ||
| atAGlanceElements = []; |
Contributor
There was a problem hiding this comment.
Suggested change
| atAGlanceElements = []; | |
| atAGlanceElements = [element]; |
I think we want to include the heading in the AAG elements here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored by: @emma-imber
What does this change?
Replaces the 'At a Glance' section at the top of a Filter article with a scrollable products carousel.
Summary of changes:
Why?
As part of the continuation of making improvements to The Filter articles this is a changes that we plan to A/B/C test to see whether it is worth implementing it throughout the publishing pipeline.
Screenshots
After
Before
