Handle dynamic team colours and ensure sufficient contrast #14998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmockett
force-pushed
the
jm/football-colour-contrast
branch
from
ab60389 to
636af80
Compare
jamesmockett
commented
Dec 12, 2025
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
jamesmockett
force-pushed
the
jm/football-colour-contrast
branch
from
6ddf57c to
1b12961
Compare
jamesmockett
force-pushed
the
jm/football-colour-contrast
branch
from
1b12961 to
fa1446a
Compare
jamesmockett
changed the title
jamesmockett
force-pushed
the
jm/football-colour-contrast
branch
3 times, most recently
from
afcee16 to
a3481a4
Compare
jamesmockett
force-pushed
the
jm/football-colour-contrast
branch
from
a3481a4 to
ff46223
Compare
jamesmockett
force-pushed
the
jm/football-colour-contrast
branch
from
b72755f to
355f189
Compare
jamesmockett
force-pushed
the
jm/football-colour-contrast
branch
from
355f189 to
fd3c512
Compare
Contributor
Author
|
Closing in favour of #15198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Use black or white instead of team colours for figures. Adds contrast check for team colours in graph to ensure they meet WCAG minimum contrast requirements and adds contrasting border as needed for visibility.
Why?
The bar graph is shown using team colours and need to be visible in light and dark mode.
We assume that contrast will only be needed for either light or dark mode, not both. This allows use of the existing palette declarations to always apply a border to the graph when contrast is required, but switch between a contrasting colour and transparent for light or dark mode as required.
Screenshots