feat(riff-raff-generator)!: Support generation of a subset of GuStacks#2814
Draft
feat(riff-raff-generator)!: Support generation of a subset of GuStacks#2814
GuStacks#2814Conversation
🦋 Changeset detectedLatest commit: c2cdbf2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
akash1810
force-pushed
the
multiple-riff-raff.yaml
branch
3 times, most recently
from
8ffc432 to
da71ba0
Compare
akash1810
force-pushed
the
multiple-riff-raff.yaml
branch
from
da71ba0 to
84dbd03
Compare
akash1810
force-pushed
the
multiple-riff-raff.yaml
branch
2 times, most recently
from
75a04a3 to
2d52319
Compare
akash1810
force-pushed
the
multiple-riff-raff.yaml
branch
2 times, most recently
from
b69d89e to
248932b
Compare
Add support for the scenario where we create a singleton stack for shared infrastructure alongside application stacks. For example, a singleton stack that provisions an Elastic Container Registry, and a CODE and PROD application stack that pulls images from the registry. Previously, we had to create work-arounds with multiple `App`s. BREAKING CHANGE: `RiffRaffYamlFile` can no longer be directly instantiated Instead of directly instantiating `RiffRaffYamlFile`, please use `RiffRaffYamlFile.fromApp`: ```ts // Before const app = new App(); new RiffRaffYamlFile(app); // After const app = new App(); RiffRaffYamlFile.fromApp(app); ```
akash1810
force-pushed
the
multiple-riff-raff.yaml
branch
from
248932b to
c2cdbf2
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Add support for the scenario where we create a singleton stack for shared infrastructure alongside application stacks. For example, a singleton stack that provisions an Elastic Container Registry, and a CODE and PROD application stack that pulls images from the registry.
Previously, we had to create work-arounds with multiple
Apps.Warning
BREAKING CHANGE
RiffRaffYamlFilecan no longer be directly instantiated. Instead of directly instantiatingRiffRaffYamlFile, please useRiffRaffYamlFile.fromApp:This impacts these repositories.
How to test
See added unit tests. Also see guardian/mobile-n10n#1683 as a practical example of using
RiffRaffYaml.fromStackin a repository that deploys multiple Riff-Raff projects.How can we measure success?
Supporting more scenarios.
Have we considered potential risks?
Most repositories will not be impacted by the breaking change as they use
RiffRaffYamlFileviaGuRoot. Those that directly instantiate an instance ofRiffRaffYamlFilewould need to check if this change allows them to remove some custom logic.Checklist
cc/ @jonathonherbert and @tjmw who have requested this capability.
Footnotes
Consider whether this is something that will mean changes to projects that have already been migrated, or to the CDK CLI tool. If changes are required, consider adding a checklist here and/or linking to related PRs. ↩
If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid? ↩