Skip to content

Conversation

@rpbritton
Copy link
Contributor

Problem

When Client() is instantiated without a timeout parameter, timeout=None is explicitly passed to ConnectionParams, preventing the dataclass default_factory from activating. This causes HTTP operations to hang indefinitely.

Solution

Explicitly set timeout = httpx.Timeout(10.0) when timeout is None in both Client and AsyncClient constructors, ensuring the documented 10-second default is applied.

@gtsystem
Copy link
Owner

gtsystem commented Jan 6, 2026

Thanks for reporting. It seems a similar issue was already present before the recent refactoring and was probably not cached due to the error in the test suite that is now failing. Can you also adapt the tests?

@rpbritton
Copy link
Contributor Author

Thanks for reporting. It seems a similar issue was already present before the recent refactoring and was probably not cached due to the error in the test suite that is now failing. Can you also adapt the tests?

Done!

@gtsystem gtsystem merged commit 5524ba8 into gtsystem:master Jan 7, 2026
17 checks passed
@gtsystem
Copy link
Owner

gtsystem commented Jan 8, 2026

Fix released as lightkube version 0.19.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants