Skip to content

Update svgcairo to work with librsvg version 2.51.0 and greater#13

Open
dalpd wants to merge 1 commit intogtk2hs:masterfrom
dalpd:bump-librsvg
Open

Update svgcairo to work with librsvg version 2.51.0 and greater#13
dalpd wants to merge 1 commit intogtk2hs:masterfrom
dalpd:bump-librsvg

Conversation

@dalpd
Copy link
Copy Markdown

@dalpd dalpd commented Oct 22, 2021

librsvg in nixpkgs was updated to version 2.52.0 recently which broke the svgcairo build because one of the headers is renamed in version 2.51.0.

This bumps the lower boundry for librsvg and updates the header's path.

librsvg in nixpkgs was updated to version 2.52.0 recently which broke the
svgcairo build because one of the headers is renamed in version 2.51.0.

This bumps the lower boundry for librsvg and updates the header's path.
@Bodigrim
Copy link
Copy Markdown

Bodigrim commented Jan 4, 2024

Hit this today. Could someone please merge and make a release? @hamishmack?

@ocharles
Copy link
Copy Markdown

ocharles commented Jan 5, 2024

I'm able to merge this, but I don't have Hackage upload rights. @hamishmack are you able to grant me those? Then I can take care of this.

@Bodigrim
Copy link
Copy Markdown

@hamishmack just a reminder about this.

@zarakshR
Copy link
Copy Markdown

I can confirm that this issue affects me

@Bodigrim
Copy link
Copy Markdown

@hamishmack could you please possibly merge this and/or give @ocharles Hackage upload rights?

@ulidtko
Copy link
Copy Markdown

ulidtko commented Mar 4, 2025

Ping @hamishmack... Three things are needed to get master to build:

Please merge!

@ulidtko
Copy link
Copy Markdown

ulidtko commented Mar 5, 2025

FWIW, I've combined the 3 patches — https://github.com/zoominsoftware/svgcairo/tree/maint/patches

So in stack.yaml, that'd be

extra-deps:
  ...

  # ghc-vis & its deps; svgcairo vendored, due to https://github.com/gtk2hs/svgcairo/pull/13
  - ghc-vis-0.9.3.1@sha256:8bb5d717db339ea4cabc63f25f45114a3d5c3e7a07da85d6ab9b08b58b8a485f,2770
  - ghc-heap-view-0.6.4.1@sha256:3db52b253513cf086fc80c878efc5582116323307eda41e066de908cd33215ec,3270
  - xdot-0.3.0.5@sha256:61450e3165cf8f187797304e84010ab1263dc055d7cdfdb84b5ea5508a68f527,2197
  - github: zoominsoftware/svgcairo
    commit: 1852132e939fc953b61b55e6752b20b751fbae56

And in cabal.project,

source-repository-package
  type: git
  location: https://github.com/zoominsoftware/svgcairo.git
  tag: 1852132e939fc953b61b55e6752b20b751fbae56

Again: this includes all 3 fixes from the previous comment ☝️ and installs as-is (in my case, as dependency of ghc-vis), modulo the native dependencies: librsvg, libgtk3, graphviz, etc.

Might be useful. Until maintainers merge these here in the origin repo, anyway.

@Lysxia
Copy link
Copy Markdown

Lysxia commented May 31, 2025

@hamishmack this would be nice to fix.

ping @dmwit who's also listed on Hackage as a maintainer of svgcairo. Can you give upload rights to ocharles?

@dmwit
Copy link
Copy Markdown
Contributor

dmwit commented Jul 12, 2025

Not sure if I'm overstepping my bounds or whatever, but I've added @ocharles to the Hackage maintainer list.

@hyper-analysis
Copy link
Copy Markdown

The maintainers are gone. Who can move forward ?

@ulidtko
Copy link
Copy Markdown

ulidtko commented Dec 5, 2025

This is such a nicely small package... 500 lines everything.

I can push it forward @PhilosophicalWarfare. Basically, already did (but in a fork).

All that's left is to publish a version.

Ping @hamishmack once more, as he was active back in March this year... Hamish, do you accept maintainership volunteers?

Also ping @GuillaumedeVolpiano @wenkokke @wavewave -- if any of you know how to reach gtk2hs people, please tell us! I've checked the gtk2hs mailman lists on SourceForge, those don't seem to be getting responses since ~2020. Didn't have much luck on IRC either.

This build breakage is a simple matter 🤕 has all the fixes written, tested and ready -- just need to be merged & released. Quite a few people are affected... please see this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants