Skip to content

Fix/user mask overwrite #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rfievet merged 2 commits into from
Apr 7, 2026
Merged

Fix/user mask overwrite #63

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b95570
Stop writing AI mask predictions into user masks
Apr 2, 2026
abfb55e
Remove redundant newUserMaskData logic
Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 4 additions & 21 deletions iris/segmentation/static/javascripts/segmentation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2788,37 +2788,20 @@ async function legacyPredictMask(){
}

const newMaskData = new Uint8Array(currentMaskData);
const newUserMaskData = new Uint8Array(currentUserMaskData);


// Only update the mask where the user did not draw to
let aiPixelsApplied = 0;
for (var i = 0; i < results.data.length; i++) {
if (!currentUserMaskData[i]){
newMaskData[i] = results.data[i];
// CRITICAL: Also mark this pixel as "drawn" in userMask
// so it gets saved and rendered
newUserMaskData[i] = 1;
aiPixelsApplied++;
}
}

console.log(`[IRIS] AI Prediction: Applied ${aiPixelsApplied} AI-predicted pixels`);
// Update store with prediction results (ONLY SOURCE)

// Update store with prediction results
window.setMaskDataInStore(newMaskData, maskShape[0], maskShape[1]);
window.setUserMaskDataInStore(newUserMaskData);
console.log('[IRIS Migration] ✅ Applied prediction results using React store');

// Verify the store was updated
const verifyMaskData = window.getMaskDataFromStore();
const verifyUserMaskData = window.getUserMaskDataFromStore();
let verifyAiPixels = 0;
for (var i = 0; i < verifyMaskData.length; i++) {
if (verifyUserMaskData[i] === 1 && verifyMaskData[i] !== 0){
verifyAiPixels++;
}
}
console.log(`[IRIS] AI Prediction: Verified ${verifyAiPixels} total pixels in store after update`);

reload_hidden_mask();
render_mask();
Expand Down
Loading