Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces debug mode support, improves the configuration UI with better documentation and responsive styling, and adds path normalization for backward compatibility with single-string image paths.
- Adds debug mode CLI flags and API exposure for conditional debug logging in the frontend
- Improves configuration UI with clearer documentation, better examples, and percentage-based responsive styling
- Normalizes legacy single-string image paths to dictionary format for consistent handling
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| iris/cli.py | Adds --debug and --production CLI options to the launch command |
| iris/api/routes/config.py | Exposes debug flag in the project config API response |
| iris/project.py | Adds path normalization logic to convert single-string image paths to dictionary format |
| iris/tests/test_api_config.py | Adds test coverage for debug flag and path normalization functionality |
| src/components/preferences/ProjectConfigTab.tsx | Implements conditional debug logging based on server debug mode |
| src/components/preferences/config/PathListEditor.tsx | Updates styling from fixed width to percentage-based responsive design |
| src/components/preferences/config/GeneralSection.tsx | Improves documentation with restructured help text, clearer examples, and better field labels |
Comments suppressed due to low confidence (1)
iris/project.py:71
- Unnecessary 'pass' statement.
pass
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
loriab
force-pushed
the
config_tweaks_rb1
branch
from
e08c773 to
3bca066
Compare
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| regex_images.match(image_path).groups()[0] | ||
| for image_path in images |
There was a problem hiding this comment.
Variable shadowing issue: the loop variable 'image_path' on line 178 is being reused inside the loop at lines 197-198 for the list comprehension iteration variable. This shadows the outer loop variable, which means the exception message on line 202 will reference the last item from the 'images' list instead of the original 'image_path' from the outer loop. Consider renaming the inner loop variable to something like 'img_file' to avoid confusion and ensure error messages are accurate.
| regex_images.match(image_path).groups()[0] | |
| for image_path in images | |
| regex_images.match(img_file).groups()[0] | |
| for img_file in images |
| const msg = `Validation failed: ${validationResult.errors.join('\n')}`; | ||
| setError(msg); |
There was a problem hiding this comment.
The error message uses '\n' for line breaks, but these won't be rendered as line breaks in the HTML div element. To display multi-line error messages properly, either add a CSS style like 'whiteSpace: "pre-wrap"' to the error div elements (lines 316-326 and 352-361), or split the error string by '\n' and render each line as a separate element with
tags between them.
Description
some changes after poking around the General panel of config tab
Changes
iris launch. Upon debug=T, have the "Save Complete Configuration" button print the config to console.Demo
Related Issue
Closes #[issue_number]
Additional Notes
Any additional context or notes for reviewers.