feat(gsd): add enhanced verification checks for auto-mode#3468
Open
OfficialDelta wants to merge 5 commits intogsd-build:mainfrom
Open
feat(gsd): add enhanced verification checks for auto-mode#3468OfficialDelta wants to merge 5 commits intogsd-build:mainfrom
OfficialDelta wants to merge 5 commits intogsd-build:mainfrom
Conversation
Contributor
🔴 PR Risk Report — CRITICAL
Affected Systems
File Breakdown
|
added 5 commits
April 4, 2026 23:43
Adds 4 pre-execution checks that run before each task: - File ops review: surfaces create/edit/delete intent for manual review - Read-before-create guard: fails when plan reads a file before creating it - Package existence: verifies npm packages exist before install attempts - Interface contract: warns on mismatched function signatures Includes preference types and validation for enhanced_verification settings.
Adds 3 post-execution checks that run after task completion: - Import resolution: verifies relative imports resolve to existing files - Export verification: confirms exported symbols are defined - Type consistency: validates function return types match declarations All checks follow the permissive-by-default pattern (R012) - warnings don't block.
…cation Integrates pre/post-execution checks into auto-mode: - auto-verification.ts: runEnhancedPreChecks/runEnhancedPostChecks integration - auto-post-unit.ts: pause control flow when blocking checks fail - Respects enhanced_verification_strict preference for blocking vs warning Control flow: blocking failures trigger auto-mode pause for user review.
The enhanced_verification_* preferences were validated and typed but not included in mergePreferences(), causing project-level overrides to be silently ignored. This fix ensures project preferences properly merge with user-level defaults.
…cation - pre-execution-pause-wiring.test.ts: Tests blocking check → pause control flow - enhanced-verification-integration.test.ts: End-to-end integration coverage Verifies that blocking pre-execution failures trigger auto-mode pause and that the enhanced verification pipeline integrates correctly with existing verification infrastructure.
0b8a475 to
c4091e0
Compare
Collaborator
|
This PR has merge conflicts with the base branch. Please rebase or merge 🤖 Automated PR audit — 2026-04-04 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
What: Adds 7 mechanical verification checks that run before and after each auto-mode task.
Why: Catches common agent mistakes (reading files before creating them, installing non-existent packages, broken imports) earlier in the pipeline.
How: Pre-execution checks validate the task plan; post-execution checks validate the result. Blocking failures pause auto-mode for review.
What
Pre-execution checks (before task starts)
Post-execution checks (after task completes)
Why
Auto-mode can generate code that compiles but has subtle issues:
npm install foowherefoo404s)These checks catch issues before they cascade into harder-to-debug failures downstream.
How
Integration
runEnhancedPreChecks()andrunEnhancedPostChecks()in auto-verification.tspauseNeeded = truein auto-post-unit.tsPreferences
Design decisions
Promise.all()for concurrent npm lookups..js→.tsconvention.Testing
pre-execution-checks.test.ts,post-execution-checks.test.tsenhanced-verification-integration.test.ts,pre-execution-pause-wiring.test.tsFiles changed
pre-execution-checks.tspost-execution-checks.tsauto-verification.tsauto-post-unit.tspreferences-types.tspreferences-validation.tspreferences.tsverification-evidence.tsAI-assisted: This PR was developed using GSD-2's own auto-mode pipeline. All code has been reviewed and is understood by the author.