fix: prevent Enter key infinite loop in interview notes mode

[yokotoka]

Summary

Fixes #3449

• The goNextOrSubmit() function in the interview UI re-opened the notes field every time Enter was pressed if the cursor was on "None of the above", creating an infinite loop where the user could never advance past the current question
• Added && !states[currentIdx].notesVisible guard to the auto-open condition so it only triggers on the initial selection, not when the user is confirming already-typed notes

Root Cause

Commit b80eec6 (#3081, fix for #2715) added auto-open logic that opens the notes field when "None of the above" is selected. However, goNextOrSubmit() is also called when Enter is pressed from within notes mode (line 387). This created a cycle:

1. Enter in notes mode → focusNotes = false → goNextOrSubmit()
2. goNextOrSubmit() sees cursorIndex === noneOrDoneIdx → focusNotes = true
3. User presses Enter again → back to step 1

Fix

The auto-open check now also verifies !states[currentIdx].notesVisible. When notes have already been shown (notesVisible = true from the initial Tab or auto-open), the guard prevents re-opening and lets the flow advance normally.

The original #2715 fix is preserved: when a user first selects "None of the above" (before notes have been shown), notesVisible is false and the auto-open still triggers correctly.

Test plan

• Select "None of the above" → notes field auto-opens (original Bug: Ask-user-questions UI lacks free-text input and can trap users in a loop #2715 behavior preserved)
• Type a note → press Enter → advances to next question or review screen
• Press Tab to add notes on any option → type → press Enter → advances correctly
• Press Tab to add notes → press Tab again to close → press Enter → advances correctly

🤖 Generated with Claude Code

[github-actions]

🟡 PR Risk Report — MEDIUM

Files changed	2
Systems affected	1
Overall risk	🟡 MEDIUM

Affected Systems

Risk	System
🟡 medium	TUI Components

File Breakdown

Risk	File	Systems
🟡	src/resources/extensions/shared/interview-ui.ts	TUI Components
⚪	src/resources/extensions/shared/tests/interview-enter-loop.test.ts	(unclassified)

[Copilot]

Pull request overview

This PR fixes an interaction bug in the shared TUI interview flow where pressing Enter while editing notes could re-trigger the “auto-open notes on ‘None of the above’” behavior, trapping users in a loop and preventing progression.

Changes:

• Adds a !states[currentIdx].notesVisible guard to the “auto-open notes” condition in goNextOrSubmit() to prevent re-opening notes after they’ve already been shown once for the current question.
• Adds an inline comment clarifying why the guard exists (Enter-from-notes confirmation path).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jeremymcs]

This PR has merge conflicts with the base branch. Please rebase or merge main to resolve before review can proceed.

🤖 Automated PR audit — 2026-04-04