fix(gsd): fail empty plan-milestone workers loudly#3417
Closed
mastertyko wants to merge 3 commits intogsd-build:mainfrom
Closed
fix(gsd): fail empty plan-milestone workers loudly#3417mastertyko wants to merge 3 commits intogsd-build:mainfrom
mastertyko wants to merge 3 commits intogsd-build:mainfrom
Conversation
Contributor
🔴 PR Risk Report — CRITICAL
Affected Systems
File Breakdown
|
Contributor
Author
|
Closing this for now to keep the queue clean. The issue remains tracked in #3405 and can be reopened later as a cleaner standalone fix from current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
What: Rejects empty
plan-milestoneroadmap stubs and turns the resulting stuck headless lane into an explicit error.Why: A milestone worker could appear to produce its artifact while actually writing an empty roadmap shell, which left downstream workers stuck and the headless lane looking falsely successful.
How: Tighten artifact verification for
plan-milestoneoutputs and mark stuck terminal notifications as error exits in headless mode.What
This change makes milestone planning fail loudly when the produced roadmap is only an empty scaffold.
Affected areas:
src/resources/extensions/gsd/auto-recovery.tssrc/resources/extensions/gsd/tests/integration/auto-recovery.test.tssrc/headless.tssrc/headless-events.tssrc/tests/headless-detection.test.tssrc/tests/headless-v2-migration.test.tsWhy
Closes #3405.
An empty
plan-milestoneroadmap stub is not a valid planning artifact, but the current verification path could accept it and let the workflow continue. That produced a stuck loop where downstream workers waited on planning that had not actually happened, and headless mode could hide the failure.How
verifyExpectedArtifact()now rejectsplan-milestoneroadmap stubs with zero slices, and the headless pipeline treats terminalStuck:notifications as explicit error exits instead of a quiet success path. Regression coverage locks both behaviors down.Change type
fix— Bug fixfeat— New feature or capabilityrefactor— Code restructuring (no behavior change)test— Adding or updating testsdocs— Documentation onlychore— Build, CI, or tooling changesScope
pi-tui— Terminal UIpi-ai— AI/LLM layerpi-agent-core— Agent orchestrationpi-coding-agent— Coding agentgsd extension— GSD workflownative— Native bindingsci/build— Workflows, scripts, configBreaking changes
Test plan
Verified locally with the full CI mirror gate:
npm run buildnpm run typecheck:extensionsnpm run test:unitnpm run test:integrationThe final truth phase was re-run in a plain verification clone on the exact branch head after the worktree hit a late verifier-environment stall.
AI disclosure