refactor: deduplicate config defaults into CONFIG_DEFAULTS constant#1708
Merged
refactor: deduplicate config defaults into CONFIG_DEFAULTS constant#1708
Conversation
Fixes #1707 Extracts config defaults from loadConfig() into an exported CONFIG_DEFAULTS constant in core.cjs. config.cjs and verify.cjs now reference CONFIG_DEFAULTS instead of duplicating values, preventing future divergence.
trek-e
approved these changes
Apr 4, 2026
Collaborator
trek-e
left a comment
trek-e
left a comment
There was a problem hiding this comment.
Clean DRY refactoring. CONFIG_DEFAULTS in core.cjs as the single source of truth is the right approach. Verified that config.cjs and verify.cjs now reference it instead of duplicating values. All CI green. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadConfig()into an exportedCONFIG_DEFAULTSconstant incore.cjsconfig.cjsbuildNewProjectConfig()now referencesCONFIG_DEFAULTSfor shared scalar valuesverify.cjscmdHealthCheck()config repair now referencesCONFIG_DEFAULTSFixes #1707
Test plan
gsd-tools.cjs config-new-projectproduces same config as beforegsd-tools.cjs health --fixconfig repair produces same config as before