Allow simple enums in Input #99
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for setting up the input buffers currently causes a crash when getting enums for input because it calculates the size of the input using
core::mem::size_of()instead of bincode, which have different results. I wrote a new test to demonstrate the issue. Without the changes in this PR, it panics:By updating the initial size to use bincode::serialized_size(&T::Input::default()), the problem is fixed. This does not solve for cases when the enum variants have data and are encoded to different sized, which would require a much larger change.