Techdebt/xcodecloud tests

.circleci/config.yml

@@ -16,7 +16,7 @@ jobs:
       HOMEBREW_NO_AUTO_UPDATE: 1
       FASTLANE_SKIP_UPDATE_CHECK: 1
       FL_OUTPUT_DIR: output
-      FASTLANE_LANE: run_all_tests_iPhone16ProMax
+      FASTLANE_LANE: run_unit_tests_iPhone16ProMax
       XCODE_SCHEME: brainwalletUnitTests
       XCODE_PROJECT: brainwallet.xcodeproj
       FASTLANE_XCODEBUILD_SETTINGS_TIMEOUT: 120
@@ -198,11 +198,8 @@ jobs:
             find ~/Library/Developer/CoreSimulator/Devices/*/data/Library/Logs/CrashReporter/ -name "*Brainwallet*" -type f -exec echo "Found simulator crash log: {}" \; -exec cat {} \; || echo "No simulator crash logs found"
             log show --predicate 'process == "Brainwallet"' --last 10m || echo "No system logs found for Brainwallet"
           when: on_fail
-
-      - store_artifacts:
-          path: output
       - store_test_results:
-          path: output/scan
+          path: test_output   #.This works path: output/scan
       - store_artifacts:
           path: ~/Library/Logs/DiagnosticReports
           destination: crash-logs

.github/PULL_REQUEST_TEMPLATE.md

@@ -4,12 +4,11 @@
 ## Platform
 - [ ] Android
 - [ ] iOS
-- [ ] Games-Unity
-- [ ] DevOps (AWS)
-- [ ] C/Golang 
+- [ ] Games-Unity 
 
 ## 🎯 Type of Change
 <!-- Mark the relevant option with an [x] -->
+- [ ] 🚀  Release
 - [ ] 🐛 Bug fix
 - [ ] ✨ New feature
 - [ ] 🔧 Refactoring (code change that neither fixes a bug nor adds a feature)
@@ -18,12 +17,7 @@
 - [ ] ⚡ Performance improvement
 - [ ] 🧪 Test addition or improvement
 
-## 📋 Changes
-<!-- List the key changes made in this PR -->
-- 
-- 
-
-### 🔗 Related Issues
+## 📋 Changes / Issues
 <!-- Link any related issues using "Fixes #issue_number" or "Closes #issue_number" -->
 - Fixes #
 - Related to #

BrainwalletUITests/LockScreenViewUITests.swift

@@ -0,0 +1,67 @@
+//
+//  LockScreenViewUITests.swift
+//  BrainwalletUITests
+//
+//  Created by Kerry Washington on 08/02/2026.
+//  Copyright © 2026 Grunt Software, LTD. All rights reserved.
+//
+
+import XCTest
+
+final class LockScreenViewUITests: XCTestCase {
+
+    var app: XCUIApplication!
+
+    override func setUpWithError() throws {
+        try super.setUpWithError()
+        continueAfterFailure = false
+
+        app = XCUIApplication()
+        Task {
+            await setupSnapshot(app)
+        }
+        app.launch()
+
+        let isLockScreenViewShowing = app.descendants(matching: .any)["Lock Screen Footer View"].waitForExistence(timeout: 2)
+        try XCTSkipUnless(isLockScreenViewShowing, "Lock Screen Footer View not showing, skipping these tests")
+    }
+
+    override func tearDownWithError() throws {
+        app.terminate()
+    }
+
+    @MainActor
+    func testLockScreenView() throws {
+
+        XCTAssertTrue(app.descendants(matching: .any)["Lock Screen Footer View"].exists)
+
+        app.activate()
+        app/*@START_MENU_TOKEN@*/.buttons["moon.stars"]/*[[".otherElements",".buttons[\"Clear Night\"]",".buttons[\"moon.stars\"]"],[[[-1,2],[-1,1],[-1,0,1]],[[-1,2],[-1,1]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+        app/*@START_MENU_TOKEN@*/.buttons["sun.max"]/*[[".otherElements",".buttons[\"Brightness Higher\"]",".buttons[\"sun.max\"]"],[[[-1,2],[-1,1],[-1,0,1]],[[-1,2],[-1,1]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+        app/*@START_MENU_TOKEN@*/.buttons["qrcode"]/*[[".otherElements",".buttons[\"Qr Code\"]",".buttons[\"qrcode\"]"],[[[-1,2],[-1,1],[-1,0,1]],[[-1,2],[-1,1]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+
+        let element = app/*@START_MENU_TOKEN@*/.buttons["8"]/*[[".otherElements.buttons[\"8\"]",".buttons[\"8\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
+        element.swipeDown()
+        app/*@START_MENU_TOKEN@*/.buttons["trash"]/*[[".otherElements",".buttons[\"Trash\"]",".buttons[\"trash\"]"],[[[-1,2],[-1,1],[-1,0,1]],[[-1,2],[-1,1]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+        app/*@START_MENU_TOKEN@*/.buttons["Cancel"]/*[[".otherElements.buttons[\"Cancel\"]",".buttons[\"Cancel\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+        app/*@START_MENU_TOKEN@*/.buttons["1"]/*[[".otherElements.buttons[\"1\"]",".buttons[\"1\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+        app/*@START_MENU_TOKEN@*/.buttons["2"]/*[[".otherElements.buttons[\"2\"]",".buttons[\"2\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+        app/*@START_MENU_TOKEN@*/.buttons["3"]/*[[".otherElements.buttons[\"3\"]",".buttons[\"3\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+
+        let element2 = app/*@START_MENU_TOKEN@*/.buttons["4"]/*[[".otherElements.buttons[\"4\"]",".buttons[\"4\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
+        element2.tap()
+
+        let element3 = app/*@START_MENU_TOKEN@*/.buttons["arrow.backward"]/*[[".otherElements.buttons[\"arrow.backward\"]",".buttons[\"arrow.backward\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
+        element3.doubleTap()
+        element3.tap()
+        element2.tap()
+        app/*@START_MENU_TOKEN@*/.buttons["5"]/*[[".otherElements.buttons[\"5\"]",".buttons[\"5\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+        app/*@START_MENU_TOKEN@*/.buttons["6"]/*[[".otherElements.buttons[\"6\"]",".buttons[\"6\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+        app/*@START_MENU_TOKEN@*/.buttons["7"]/*[[".otherElements.buttons[\"7\"]",".buttons[\"7\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+        element.tap()
+        app/*@START_MENU_TOKEN@*/.buttons["9"]/*[[".otherElements.buttons[\"9\"]",".buttons[\"9\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+        app/*@START_MENU_TOKEN@*/.buttons["0"]/*[[".otherElements.buttons[\"0\"]",".buttons[\"0\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+        element3.tap()
+        element3.doubleTap()
+     }
+}

BrainwalletUITests/StartViewUITests.swift

@@ -0,0 +1,123 @@
+//
+//  StartViewUITests.swift
+//
+//  Created by Kerry Washington on 08/02/2026.
+//  Copyright © 2026 Grunt Software, LTD. All rights reserved.
+//
+
+import XCTest
+
+final class StartViewUITests: XCTestCase {
+var app: XCUIApplication!
+
+override func setUpWithError() throws {
+    try super.setUpWithError()
+    continueAfterFailure = false
+
+    app = XCUIApplication()
+    Task {
+        await setupSnapshot(app)
+    }
+    app.launch()
+
+
+    let isStartViewShowing = app.otherElements["Welcome Moji Demo View"].waitForExistence(timeout: 2)
+    try XCTSkipUnless(isStartViewShowing, "StartView not showing, skipping these tests")
+}
+
+override func tearDownWithError() throws {
+    app.terminate()
+}
+
+    @MainActor
+    func testStartToReadyPath() throws {
+        app = XCUIApplication()
+        app.activate()
+        app/*@START_MENU_TOKEN@*/.buttons["darkModePreference"]/*[[".otherElements",".buttons[\"Brightness Higher\"]",".buttons[\"darkModePreference\"]"],[[[-1,2],[-1,1],[-1,0,1]],[[-1,2],[-1,1]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+        app/*@START_MENU_TOKEN@*/.buttons["darkModePreference"]/*[[".otherElements",".buttons[\"Clear Night\"]",".buttons[\"darkModePreference\"]"],[[[-1,2],[-1,1],[-1,0,1]],[[-1,2],[-1,1]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+        app/*@START_MENU_TOKEN@*/.buttons["readyCreateNewBrainwalletButton"]/*[[".otherElements",".buttons[\"Create New Wallet\"]",".buttons[\"readyCreateNewBrainwalletButton\"]"],[[[-1,2],[-1,1],[-1,0,1]],[[-1,2],[-1,1]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+        app/*@START_MENU_TOKEN@*/.buttons["Setup app passcode"]/*[[".otherElements.buttons[\"Setup app passcode\"]",".buttons[\"Setup app passcode\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+
+        let element = app/*@START_MENU_TOKEN@*/.buttons["1"]/*[[".otherElements.buttons[\"1\"]",".buttons[\"1\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
+        element.tap()
+
+        let element2 = app/*@START_MENU_TOKEN@*/.buttons["2"]/*[[".otherElements.buttons[\"2\"]",".buttons[\"2\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
+        element2.tap()
+
+        let element3 = app/*@START_MENU_TOKEN@*/.buttons["3"]/*[[".otherElements.buttons[\"3\"]",".buttons[\"3\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
+        element3.tap()
+
+        let arrowBackwardElementsQuery = app.buttons.matching(identifier: "arrow.backward")
+        let element4 = arrowBackwardElementsQuery.element(boundBy: 1)
+        element4.doubleTap()
+        element4.tap()
+        element3.tap()
+
+        let element5 = app/*@START_MENU_TOKEN@*/.buttons["4"]/*[[".otherElements.buttons[\"4\"]",".buttons[\"4\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
+        element5.tap()
+
+        let element6 = app/*@START_MENU_TOKEN@*/.buttons["5"]/*[[".otherElements.buttons[\"5\"]",".buttons[\"5\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
+        element6.tap()
+
+        let element7 = app/*@START_MENU_TOKEN@*/.buttons["6"]/*[[".otherElements.buttons[\"6\"]",".buttons[\"6\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
+        element7.tap()
+
+        let element8 = arrowBackwardElementsQuery.element(boundBy: 0)
+        element8.tap()
+
+        let element9 = app/*@START_MENU_TOKEN@*/.buttons["7"]/*[[".otherElements.buttons[\"7\"]",".buttons[\"7\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
+        element9.tap()
+
+        let element10 = app/*@START_MENU_TOKEN@*/.buttons["8"]/*[[".otherElements.buttons[\"8\"]",".buttons[\"8\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
+        element10.tap()
+
+        let element11 = app/*@START_MENU_TOKEN@*/.buttons["9"]/*[[".otherElements.buttons[\"9\"]",".buttons[\"9\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
+        element11.tap()
+
+        let element12 = app/*@START_MENU_TOKEN@*/.buttons["0"]/*[[".otherElements.buttons[\"0\"]",".buttons[\"0\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
+        element12.tap()
+        element8.tap()
+        element.doubleTap()
+        element.doubleTap()
+        element.tap()
+        element.tap()
+        element2.tap()
+        element6.tap()
+        element3.tap()
+        element5.tap()
+        element6.tap()
+        element7.tap()
+        element9.tap()
+        element10.tap()
+        element11.tap()
+        element12.tap()
+        element.tap()
+        element.tap()
+        element.doubleTap()
+    }
+
+    @MainActor
+    func testStartToRestorePath() throws {
+        app = XCUIApplication()
+        app.activate()
+        app/*@START_MENU_TOKEN@*/.buttons["restoreYourBrainwalletButton"]/*[[".otherElements",".buttons[\"Restore with Seed Phrase\"]",".buttons[\"restoreYourBrainwalletButton\"]"],[[[-1,2],[-1,1],[-1,0,1]],[[-1,2],[-1,1]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+        app/*@START_MENU_TOKEN@*/.buttons["Restore your Brainwallet"]/*[[".otherElements.buttons[\"Restore your Brainwallet\"]",".buttons[\"Restore your Brainwallet\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+
+        let element = app/*@START_MENU_TOKEN@*/.buttons["1"]/*[[".otherElements.buttons[\"1\"]",".buttons[\"1\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
+        element.tap()
+
+        let element2 = app/*@START_MENU_TOKEN@*/.buttons["2"]/*[[".otherElements.buttons[\"2\"]",".buttons[\"2\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
+        element2.tap()
+
+        let element3 = app/*@START_MENU_TOKEN@*/.buttons["3"]/*[[".otherElements.buttons[\"3\"]",".buttons[\"3\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
+        element3.tap()
+
+        let element4 = app/*@START_MENU_TOKEN@*/.buttons["4"]/*[[".otherElements.buttons[\"4\"]",".buttons[\"4\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
+        element4.tap()
+        element.tap()
+        element2.tap()
+        element3.tap()
+        element4.tap()
+     }
+}
+

BrainwalletUnitTests/APITests.swift

@@ -41,3 +41,4 @@ class APITests: XCTestCase {
 		}
 	}
 }
+

BrainwalletUnitTests/Audio Tests/AudioTests.swift

@@ -0,0 +1,36 @@
+//
+//  AudioTests.swift
+//  BrainwalletUnitTests
+//
+//  Created by Kerry Washington on 12/02/2026.
+//  Copyright © 2026 Grunt Software, LTD. All rights reserved.
+//
+
+import Testing
+import SwiftUI
+import AudioToolbox
+
+@testable import brainwallet
+
+
+class MockAudioServices: AudioServicesProtocol {
+
+    var createCalled = false
+    var addCompletionCalled = false
+    var playCalled = false
+
+    func createSystemSoundID(url: CFURL, id: inout SystemSoundID) {
+        createCalled = true
+        id = 123
+    }
+
+    func addCompletion(id: SystemSoundID) {
+        addCompletionCalled = true
+    }
+
+    func play(id: SystemSoundID) {
+        playCalled = true
+    }
+
+    func dispose(id: SystemSoundID) {}
+}

BrainwalletUnitTests/Audio Tests/SoundsHelperTests.swift

@@ -0,0 +1,54 @@
+//
+//  SoundsHelperTests.swift
+//  BrainwalletUnitTests
+//
+//  Created by Kerry Washington on 12/02/2026.
+//  Copyright © 2026 Grunt Software, LTD. All rights reserved.
+//
+import XCTest
+import Testing
+import SwiftUI
+import AudioToolbox
+
+@testable import brainwallet
+
+class SoundsHelperTests: XCTestCase {
+
+    var mockAudio: MockAudioServices!
+    var sut: SoundsHelper!
+
+    override func setUp() {
+        super.setUp()
+        mockAudio = MockAudioServices()
+        sut = SoundsHelper(audioService: mockAudio,
+                           bundle: Bundle(for: Self.self))
+    }
+
+    func test_play_whenFileExists_callsAudioServices() {
+        // Given
+        let bundle = Bundle(for: Self.self)
+        sut = SoundsHelper(audioService: mockAudio, bundle: bundle)
+
+        // When
+        sut.play(filename: "errorsound", type: "mp3")
+
+        // Then
+        XCTAssertTrue(mockAudio.createCalled)
+        XCTAssertTrue(mockAudio.addCompletionCalled)
+        XCTAssertTrue(mockAudio.playCalled)
+    }
+
+    func test_play_whenFileDoesNotExist_doesNotCallAudioServices() {
+        // Given
+        let emptyBundle = Bundle()
+        sut = SoundsHelper(audioService: mockAudio, bundle: emptyBundle)
+
+        // When
+        sut.play(filename: "non_existing_file")
+
+        // Then
+        XCTAssertFalse(mockAudio.createCalled)
+        XCTAssertFalse(mockAudio.addCompletionCalled)
+        XCTAssertFalse(mockAudio.playCalled)
+    }
+}