Skip to content

Techdebt/add private submodule 175 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcw-grunt merged 15 commits into from
Aug 19, 2025
Merged

Techdebt/add private submodule 175 #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a2f5663
📸 Reorganized test structure Added Screenshots (#61)
kcw-grunt Jul 29, 2025
0626b63
Set desired ios-games commit
kcw-grunt Aug 15, 2025
6a39ac8
Reset and added the 2 projects
kcw-grunt Aug 15, 2025
4bf298d
Set a private filter in gitignore
kcw-grunt Aug 15, 2025
5f7e130
Update ios-games commit
kcw-grunt Aug 15, 2025
d809835
updated ios games
kcw-grunt Aug 15, 2025
31731b4
removed storekit file and ios-games submodules
kcw-grunt Aug 15, 2025
bdda7c3
Update README.md
kcw-grunt Aug 15, 2025
bce8cf9
Merge branch 'develop' into techdebt/add-private-submodule-175
kcw-grunt Aug 15, 2025
899f37c
update workspace
kcw-grunt Aug 15, 2025
ffa2797
Set to the alpha v1.0.0-pre-review-brainwallet-hybrid
kcw-grunt Aug 17, 2025
e4e9e12
updated the ios-games branch
kcw-grunt Aug 17, 2025
8652637
Removed the status for the games config
kcw-grunt Aug 17, 2025
30f1b19
Updated the config to filter Private
kcw-grunt Aug 17, 2025
0c5aa0a
Merge branch 'develop' into techdebt/add-private-submodule-175
kcw-grunt Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,8 @@ jobs:
echo 'github.com ssh-rsa SHA256:Z4bsDPFhTv8vuTERTBcs6b5RHFRspyI77b7tQUsju1g' >> ~/.ssh/known_hosts
ssh-add -D
ssh-add ~/.ssh/id_rsa_*
git submodule sync --recursive
git submodule update --init --recursive --jobs=4 --filter=blob:none -- ':(exclude)Private/ios-games'
git submodule init && git submodule update --init Modules/core

# Setup environment files (MUST be before build)
Expand Down
2 changes: 2 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@
[submodule "Private/ios-games"]
path = Private/ios-games
url = https://github.com/gruntsoftware/ios-games.git
update = none
Copy link
Collaborator

@josikie josikie Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the update value is none?

Copy link
Collaborator Author

@kcw-grunt kcw-grunt Aug 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Special trick here @josikie !
This is a flag that keeps the system from automatically updating the submodule in git submodule update. In this case, we dont want it to update because it is private and sensitive.

Also, we are running CI/CD separately for that submodule.

Thanks for asking!

Copy link
Collaborator

@josikie josikie Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation! That's make sense @kcw-grunt

ignore = all
168 changes: 168 additions & 0 deletions BrainwalletHybrid.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Private/ios-games
Open in desktop
Submodule ios-games updated from cc26da to 61e269
17 changes: 17 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,23 @@ The open source code section of Brainwallet iOS

## Release Notes

### v3.6.0 Latest

#### What's Changed
🚀[Release v3.5.0] Merge into Main by @kcw-grunt in #51
Full Changelog: v3.4.2...v3.6.0\

#### Updates:
- using bundle exec fastlane single_unit_test_all
- downgrade firebase to 11.12.0
- polsih ci config
- 🦾 Chore/migrate ready onboarding
- Fix/login view crash
- 🧰 fix: Removed the thread blocking seen in the lock screen trx. loading
- Epic/settings migration (#50)
- Chore/refactor firebase analytics
- Chore/activate test coverage

### v3.3.1
- Added locale filter
- Made improvements to UI
Expand Down