Skip to content

Group 22 modifications #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fraserwill03 wants to merge 1 commit into
base: ensf400_w24
Choose a base branch
from
Open

Group 22 modifications #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
"installTools": true,
"version": "3.11"
},
"ghcr.io/warrenbuckley/codespace-features/sqlite:1": {}
"ghcr.io/warrenbuckley/codespace-features/sqlite:1": {},
"ghcr.io/meaningful-ooo/devcontainer-features/homebrew:2": {}
Copy link
Owner

@growlf growlf Feb 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting addition!

Copy link
Owner

@growlf growlf Feb 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might add some useful compatibility for people on Macs.

},

// Use 'forwardPorts' to make a list of ports inside the container available locally.
Expand Down
6 changes: 6 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,5 +91,11 @@ ADD --chown=1000:1000 --chmod=+x https://private-sw-downloads.s3.amazonaws.com/a
ADD --chown=1000:1000 --chmod=+x src/test_net.sh .
ADD --chown=1000:1000 src/nodes.list .

# Install homebrew
RUN /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"

# Add homebrew to the path
ENV PATH="/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:$PATH"
Copy link
Owner

@growlf growlf Feb 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumes the user has this folder in their host environment. Perhaps, move this mount action to the docker-compose.yml where it can be selectively run when selecting which service to bring up.


# Set default command
CMD ["/bin/zsh"]