Adding bitcask#each_key iterator and ability to skip tombstones#1
Open
grourk wants to merge 2 commits into9ce813a00fbfc5c69d04579a403ac4fdce2ce525from
Open
Adding bitcask#each_key iterator and ability to skip tombstones#1grourk wants to merge 2 commits into9ce813a00fbfc5c69d04579a403ac4fdce2ce525from
grourk wants to merge 2 commits into9ce813a00fbfc5c69d04579a403ac4fdce2ce525from
Conversation
method to iterate over keys with more efficient checking for tombstone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When iterating just the keys, if you want only the valid keys (non-tombstones) we can avoid reading the value if it's obviously not a tombstone (based on size).
At least in our case (large data values), this increases the performance of listing keys drastically.