Allow the specify-groups option to receive its value from STDIN #1004
+116
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --specify-groups option supports to read from STDIN
grosser
reviewed
May 9, 2025
Comment on lines
+127
to
+132
| context 'with specific groups provided through STDIN' do | ||
| it "groups specify_groups as specified when specify_groups is just one spec" do | ||
| allow($stdin).to receive(:read).and_return("1\n") | ||
|
|
||
| expect(call(3, specify_groups: '-')).to eq([["1"], ["2", "5"], ["3", "4"]]) | ||
| end |
Owner
There was a problem hiding this comment.
don't think we need to copy-paste all the existing tests, 1 test to cover this edge-case should be enough ?
Contributor
Author
There was a problem hiding this comment.
I felt it would be good to cover the same input scenarios, to ensure it makes no difference whether data is directly provided or retrieved from stdin. But I am totally open to amend this if you feel strong.
Owner
|
5.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the
--specify-groupsoption so it can also receive its value from standard input. This avoids problems with command line argument limits of the shell in situations with many thousands of specs.Checklist
master(if not - rebase it).code introduces user-observable changes.