Open
Conversation
ghost
force-pushed
the
zdrve/mentions-help
branch
from
44f385e to
96f70d4
Compare
ghost
force-pushed
the
zdrve/mentions-help
branch
from
96f70d4 to
9334f73
Compare
In particular, suggest rebasing
ghost
force-pushed
the
zdrve/mentions-help
branch
from
9334f73 to
8cf118f
Compare
ghost
marked this pull request as draft
Co-authored-by: Michael Grosser <michael@grosser.it>
Co-authored-by: Michael Grosser <michael@grosser.it>
grosser
approved these changes
Dec 14, 2023
ghost
marked this pull request as ready for review
Author
|
btw the reason I haven't merged this is that while this PR I think is OK as a standalone thing, I haven't yet got a good understanding of how this would in conjunction with the equivalent code in zendesk-kennel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, suggest rebasing
So far, untested
Also, maybe the fix for this should be in zendesk-kennel as well or instead of here.