Skip to content

Conversation

@HugoKlepsch
Copy link
Contributor

  • This workflow is started manually by creating a "release" in GitHub.
  • The action uses the release environment. Configure that environment so that only the desired users (eg. repo owner) can invoke the action.
  • Set up a trusted publisher so that PyPi knows that this workflow is allowed to publish. No user/password or API keys required! https://docs.pypi.org/trusted-publishers/adding-a-publisher/
  • I tested this on my fork, it seems to work. I needed to add a pyproject.toml to override the configuration you have in setup.py though: https://pypi.org/project/retrying-hk/

@HugoKlepsch
Copy link
Contributor Author

This is actually ready now 😅
I selfishly want this to go in because I want to get rid of the pinned version of retrying==1.3.4 in my projects.

@HugoKlepsch
Copy link
Contributor Author

Oh, I took screenshots to help with repo setup in GitHub. Here they are:


Adding the release environment, which is used to control who can run (or approve a run of) the workflow:

Screenshot 2025-07-14 at 07 58 27

The environment should be configured to require a reviewer. In the screenshot it is me, but you should put just yourself:

Screenshot 2025-07-14 at 07 59 43

Here is what it looks like to approve the workflow run after creating a release:

Screenshot 2025-07-14 at 09 02 20

Copy link
Owner

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@groodt groodt merged commit f0e0c77 into groodt:main Jul 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants