Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ require (
require (
github.com/go-logfmt/logfmt v0.3.0 // indirect
github.com/go-stack/stack v1.7.0 // indirect
github.com/goccy/go-yaml v1.17.1 // indirect
github.com/gorilla/context v0.0.0-20160226214623-1ea25387ff6f // indirect
github.com/kr/logfmt v0.0.0-20140226030751-b84e30acd515 // indirect
golang.org/x/net v0.0.0-20180124060956-0ed95abb35c4 // indirect
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ github.com/go-logfmt/logfmt v0.3.0 h1:8HUsc87TaSWLKwrnumgC8/YconD2fJQsRJAsWaPg2i
github.com/go-logfmt/logfmt v0.3.0/go.mod h1:Qt1PoO58o5twSAckw1HlFXLmHsOX5/0LbT9GBnD5lWE=
github.com/go-stack/stack v1.7.0 h1:S04+lLfST9FvL8dl4R31wVUC/paZp/WQZbLmUgWboGw=
github.com/go-stack/stack v1.7.0/go.mod h1:v0f6uXyyMGvRgIKkXu+yp6POWl0qKG85gN/melR3HDY=
github.com/goccy/go-yaml v1.17.1 h1:LI34wktB2xEE3ONG/2Ar54+/HJVBriAGJ55PHls4YuY=
github.com/goccy/go-yaml v1.17.1/go.mod h1:XBurs7gK8ATbW4ZPGKgcbrY1Br56PdM69F7LkFRi1kA=
github.com/gorilla/context v0.0.0-20160226214623-1ea25387ff6f h1:9oNbS1z4rVpbnkHBdPZU4jo9bSmrLpII768arSyMFgk=
github.com/gorilla/context v0.0.0-20160226214623-1ea25387ff6f/go.mod h1:kBGZzfjB9CEq2AlWe17Uuf7NDRt0dE0s8S51q0aT7Yg=
github.com/gorilla/mux v1.6.1 h1:KOwqsTYZdeuMacU7CxjMNYEKeBvLbxW+psodrbcEa3A=
Expand Down
3 changes: 2 additions & 1 deletion moroz/svc_upload_event.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"time"

"github.com/go-kit/kit/endpoint"
"github.com/goccy/go-yaml"
"github.com/pkg/errors"

"github.com/groob/moroz/santa"
Expand Down Expand Up @@ -75,7 +76,7 @@ func decodeEventUpload(ctx context.Context, r *http.Request) (interface{}, error
// decode the JSON into individual log events.
var eventPayload santa.EventUploadRequest

if err := json.NewDecoder(zr).Decode(&eventPayload); err != nil {
if err := yaml.NewDecoder(zr).Decode(&eventPayload); err != nil {
return nil, errors.Wrap(err, "decoding event upload request json")
}

Expand Down
77 changes: 77 additions & 0 deletions moroz/svc_upload_event_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
package moroz

import (
"bytes"
"compress/zlib"
"context"
"net/http"
"testing"

"github.com/gorilla/mux"
)

func TestDecodeEventUpload(t *testing.T) {
tests := []struct {
name string
inputJSON string
expectedID string
expectedError bool
}{
{
name: "Valid JSON",
inputJSON: `{"events":[{"file_sha256":"abc123","execution_time": 123456789 ,"some_field":"value"}]}`,
expectedID: "serial_number",
expectedError: false,
},
{
name: "Valid JSON with file_bundle_hash_millis as string",
inputJSON: `{"events":[{"file_bundle_hash_millis":"114"}] ,"machine_id": "serial_number"}`,
expectedID: "serial_number",
expectedError: false,
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
var buf bytes.Buffer
zw := zlib.NewWriter(&buf)
_, err := zw.Write([]byte(tt.inputJSON))
if err != nil {
t.Fatalf("failed to write compressed data: %v", err)
}
zw.Close()

req, err := http.NewRequest("POST", "/v1/santa/eventupload/serial_number", &buf)
if err != nil {
t.Fatalf("failed to create request: %v", err)
}

vars := map[string]string{"id": "serial_number"}
req = mux.SetURLVars(req, vars)

req.Header.Set("Content-Encoding", "deflate")

result, err := decodeEventUpload(context.Background(), req)
if tt.expectedError {
if err == nil {
t.Errorf("expected an error but got none")
}
return
}

if err != nil {
t.Errorf("unexpected error: %v", err)
return
}

reqResult, ok := result.(eventRequest)
if !ok {
t.Fatalf("expected eventRequest, got %T", result)
}

if reqResult.MachineID != tt.expectedID {
t.Errorf("expected MachineID %q, got %q", tt.expectedID, reqResult.MachineID)
}
})
}
}