Change localhost to moroz.local#34
Open
NickBorgersOnLowSecurityNode wants to merge 3 commits intogroob:masterfrom
Open
Change localhost to moroz.local#34NickBorgersOnLowSecurityNode wants to merge 3 commits intogroob:masterfrom
NickBorgersOnLowSecurityNode wants to merge 3 commits intogroob:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into issues with Santa not accepting the cert based on CN alone, and instead needing DN.
I also feel like the FQDN should reflect that the entity being contacted is
morozand notsanta.This required a change to the OpenSSL script to rely on a somewhat new feature for including extensions such as SANs. There is a negative here that the script now won't work with old OpenSSL versions.