Fixed #18384: Remove backticks in bulk-actions.blade.php to avoid unintentional shell_exec() call #18388
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l shell_exec() call
Member
|
TYSM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18384.
shell_exec()is being called unintentionally in bulk-actions.blade.php via the use of backticks in the hidden sort input on line 21:<input name="sort" type="hidden" value="{{`$model_name.id`}}">Since backticks are an execution operator in PHP,
shell_exec()is being called using the value of $model_name.id when the Blade template is rendered, which fails. This may cause a runtime error depending on the user's environment configuration or it may fail silently, but thevalueattribute for the input isn't set properly regardless.I've replaced the backticks and instead use string interpolation here:
<input name="sort" type="hidden" value="{{ "{$model_name}.id" }}">This now outputs the intended string (e.g.
category.id).