Skip to content

Bump php-saml to solve vulnerability #18380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ilpianista wants to merge 1 commit into from
+15 −15
Closed

Bump php-saml to solve vulnerability #18380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"nesbot/carbon": "^3.0",
"nunomaduro/collision": "^8.1",
"okvpn/clock-lts": "^1.0",
"onelogin/php-saml": "^3.4",
"onelogin/php-saml": "^3.8.1",
Copy link
Contributor

@joelpittet joelpittet Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably don't need to make this change as it is implied in the semver (at least I wouldn't, but maybe the maintainers would). 2¢

Copy link
Author

@ilpianista ilpianista Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know. However, I don't see why I should skip it and risk someone downgrading it. Hence the bump.

Copy link
Contributor

@joelpittet joelpittet Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally fair. This is more a personal quirk of mine than a strong opinion. I tend to normalize to ^3.0 since it makes diffs a bit easier to scan across projects, but I see where you're coming from.

"onnov/detect-encoding": "^2.0",
"osa-eg/laravel-teams-notification": "^2.1",
"paragonie/constant_time_encoding": "^2.3",
Expand Down
28 changes: 14 additions & 14 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading