Skip to content

Conversation

@docwilco
Copy link

@docwilco docwilco commented Apr 7, 2021

Opened for comments, let me know if people have ProductGUIDs and ProductIDs laying about

@docwilco docwilco changed the title Support for hard lock with Fanatec DD2, needs more devices Support for hard lock with Fanatec devices Apr 7, 2021
@docwilco
Copy link
Author

docwilco commented Apr 7, 2021

Tested with DD2 and CSL Elite (PS4)

@docwilco
Copy link
Author

docwilco commented Apr 7, 2021

Not quite ready yet...

@docwilco docwilco changed the title Support for hard lock with Fanatec devices WIP: Support for hard lock with Fanatec devices Apr 8, 2021
@gro-ove
Copy link
Owner

gro-ove commented Apr 22, 2021

Oh my god, that’s amazing, thank you so much! I had to idea how to do it. So is it working now for some devices?

@docwilco
Copy link
Author

It's working on a friend's CSL Elite. I still need to test/debug my DD2 some more.

You OK with the code style so far?

@gro-ove
Copy link
Owner

gro-ove commented Apr 22, 2021

Sure, although I might run auto-formatter with my settings later if that’s ok. One thing I noticed though looking at those changes, I might be wrong and I do apologize if that’s the case, but it seems as if you’re storing _productIds as private field of FanatecDD2 and then defining new private fields in new classes, but as far as I know, they wouldn’t overwrite original list of IDs. Notice how I was using protected override for all sorts of Fanatec implementations. Maybe that would help?

@docwilco
Copy link
Author

Ah, I'm new to C#, and I potentially need to read up on that a bit more. Thanks for the heads up. Is here the best place to communicate, or should I ping you somewhere when I've updated this PR?

@gro-ove
Copy link
Owner

gro-ove commented Apr 22, 2021

Do you have Telegram or Skype (my username is x4fab2)? That would be the best, if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants