Online - fix crash in server selection (Wine) #114
Conversation
|
This PR is only for reference as the repo is a bit outdated. Main maintainer will be contacted. |
|
Marking this as Ready, even if some changes are still required. |
|
I couldn't find a compiled version, so I compiled it myself. Since we don't know when this will be merged into the main branch, this should work for now. It requires a newer version but works fine as is. DownloadI'm providing the compiled version for x86. If the URL doesn't work, please try another mirror: If any of the file/links seem suspicious, you can compile it yourself. How to apply this patch?Everything is explained in this video: Watch Tutorial Instead of downloading the original Content Manager from the site, download the patched version provided in this Pull Request/Comment. |
|
@gro-ove please 🙏 |
MrXANA91
force-pushed
the
fixCrashServerSelection
branch
from
a0cd917 to
8f4c01c
Compare
|
I just rebased this PR, I'll test it later today. Edit: yup, i forgot about it. Testing it this weekend. |
|
Hello, with the new version of pure created for Linux there will be many people having the issue with accessing the euroracer servers. Would it be possible to merge the latest master with this branch? I may need to learn how to build it but it will allow us to use the latest version of content manager with this fix. Thank you |
… + default english text in AppStrings
MrXANA91
force-pushed
the
fixCrashServerSelection
branch
from
d43c7ba to
651fd6c
Compare
PR has been rebased, testing it later today. |
|
I am having a lot of trouble getting it to compile again, I don't really know what is happening. |
|
I'm trying to build just the latest and I'm having a hard time. I do c++ but never .net c#. There is no documentation either. I'm down to 2 projects not building. I had it down to 1 with 7 errors but the project configurations got changed and I went backwards. Mind you this is without any code change just the project configuration files. Thanks for trying though |
|
So I was able to solve the problems with the CefSharp library. It seems that the files for version 114.2.120.0 are not included. However, I also have the error related to AcManager.Controls (7 errors) which does not allow the AcManager to build. Please let me know if you solve it. Thanks |
I think I have way more than 7 errors when I try to build, most of them related to On another note, I am trying to reach out to @gro-ove, without success for now. |
|
Yes the 7 errors are only on AcManager.Controls which then causes 142 errors in AcManager. So I went the route of getting the CefSharp libraries and adding then to the Libraries folder instead of getting the package from NuGet (CefSharpCommon, CefSharp.WinForms and CefSharp.Wpf version 114.2.120) and also getting the packages from NuGet and the problem is the same. Yes the errors are related to the namespace issue. The projects have several references that are not found and in some cases they have references to older versions (MoonSharp 1.6..0 and 2.0.0). So if the code built in the past the problem may be related to a configuration issue. I was also diffing the last 2 hashes and they show no change which is odd since there are supposed to be changes. |
|
So I was able to build the project using hash 09f3cc1 and with some changes to the AcManager and AcManager.Controls project files related to packages. Specifically fixing a couple of references. If update to any version after that I ended up with the same errors as the latest version. |
|
Ok I was able to built the latest hash (effa0e1) by changing all namespace entries from http://acstuff.ru to http://acstuff.club. Also, some changes to the AcManager and AcManager.Controls project files related to references which in turn change the packages.config for AcManager file project. However, when running the exe it says the version is 0.8.2136.36454 instead of 0.8.2790.39895 which is confusing. I had to switch to the actual tag to get the version to show the correct value. Thanks. By the way, the project still reports 39 warnings. Next, I'll try to manually add your workaround to create a Linux version. |
|
Your branch has an issue on file AppStrings.Designer.cs line 3697. It appear to be an unfinished merge. Let me know if I got it wrong. Thanks |
Yeah, good catch. Fixed the code. |
|
Yes. I was able to build both versions. However, I had to make changes related to the namespace and also project files and the references to certain packages/libraries. When building the latest version the exe shows on the last version (39895) but when bringing your changes manually the version of the exe changed and it shows behind. That part I don't understand yet. I haven't bring your recent changes yet so I'll try it and see. Do you know what determines the version on the exe? I thought it was thru git and its tag. This is what git is giving me: Thanks |
|
Yeah the versioning is a bit a mystery to me here, I know that most of the time Github releases and source code don't match. So I wouldn't care too much about the exe version, just warn people to disable auto-update if they use this special compiled version. |
|
Hi all, can anyone provide the latest compiled .exe? The previous compiled .exe by @MrXANA91 is recently running into problems, crashing in server selection screen. I wasn't able to build a new version despite attempting to fix some referencing issues mentioned by @SpiritFlow516 (I'm not a C# developer). |
|
Content Manager.zip |
Sorry, are you sure this is the correct version? It does not include the fix that has a toggle to "Hide images render", and will crash when viewing EuroRacers server. |
Sorry about that. It must be the latest version without the fix. I'll upload the other version soon. |
|
AssettoCorsa.zip |
5 participants
Description
This pull request aims to give (at least) a temporary solution to issue #106 and its dupplicate(s).
While the root cause could not be entirely determined, it appears that deactivating the images rendering in servers description prevent the crash from happening.
This PR adds a checkbox setting in the Online/Display category to hide images in server description (deactivated by default).
Detailed changes
HideImagesInServersDescription(deactivated by default)imgtags if the boolean setting is enabledAppStringfor theHideImagesInServersDescriptioncheckbox text :Settings_Online_HideImagesInServerDescription--> "Hide images render in servers description"Checklist
Github commands
fix #106
fix #109