-
Notifications
You must be signed in to change notification settings - Fork 11
Update CI Workflow and Dependencies #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/ci.yml
Outdated
| jobs: | ||
| ci: | ||
| runs-on: ubuntu-20.04 | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the latest ubuntu not ubuntu-latest, otherwise, the next time they change to a new one the CI will break on older OTPs versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bchassoul https://github.com/actions/runner-images?tab=readme-ov-file
Use ubuntu-24.04, so we are in controll of the version used. This will last only until GitHubb supports it, but at least it will not break CI for a lot of time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bchassoul I am referring to this https://github.com/actions/runner-images?tab=readme-ov-file
.github/workflows/ci.yml
Outdated
| jobs: | ||
| ci: | ||
| runs-on: ubuntu-20.04 | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bchassoul https://github.com/actions/runner-images?tab=readme-ov-file
Use ubuntu-24.04, so we are in controll of the version used. This will last only until GitHubb supports it, but at least it will not break CI for a lot of time.
This PR updates the CI workflow by upgrading GitHub Actions to their latest stable versions (checkout@v4 and cache@v4) and removes support for OTP 23 which is no longer listed on
erlef/setup-beam@v1.Additionally, it adds rebar3 script configuration to ensure
erlexec 2.0.7for OTP versions below 27