Add preloaded module update option #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GwendalLaurent
left a comment
GwendalLaurent
left a comment
There was a problem hiding this comment.
We should maybe document in the README the new flag
src/rebar3_grisp_build.erl
Outdated
| "Create tarball with OTP installation for online repository" | ||
| }, | ||
| {update_prebuild, $p, "update-prebuild", {boolean, false}, | ||
| "Update OTP prebuilt modules, enable if some prebuilt modules are patched" |
Member
There was a problem hiding this comment.
That clearly a detail but I think that the "," should be replaced by a "." and separate the sentence in 2.
"Update OTP prebuilt modules. Enable if some prebuilt modules are patched"
Member
|
It would be much better if we could detect that a patch requires the preloaded update step... 🤔 |
Member
|
@sylane Why do we need to update the preloaded? Is this related to the rtems unicode minimal stub? |
Contributor
Author
|
With the current patchiest for GRiSP Nano, without debug printing, there is no need for it, but if you patch the preloaded module in OTP, you need to set this flag, because the beams are prebuilt. |
ziopio
approved these changes
Jun 18, 2025
sylane
force-pushed
the
sylane/grisp-nano
branch
2 times, most recently
from
c33290a to
7f3b4f5
Compare
sylane
force-pushed
the
sylane/grisp-nano
branch
from
7f3b4f5 to
41d1ef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on grisp/grisp_tools#39