fix: fix lazy associations, LazyInitalizationErrros, address OSIV tech-debt#42
Open
balazs-szucs wants to merge 29 commits intogrimmory-tools:developfrom
Open
fix: fix lazy associations, LazyInitalizationErrros, address OSIV tech-debt#42balazs-szucs wants to merge 29 commits intogrimmory-tools:developfrom
balazs-szucs wants to merge 29 commits intogrimmory-tools:developfrom
Conversation
…erformance Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
# Conflicts: # booklore-api/src/main/java/org/booklore/controller/MetadataController.java # booklore-api/src/main/java/org/booklore/service/book/BookService.java
# Conflicts: # booklore-api/src/main/java/org/booklore/service/reader/EpubReaderService.java
…in fallback test Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
# Conflicts: # booklore-api/src/main/java/org/booklore/service/ReadingSessionService.java
# Conflicts: # booklore-api/src/main/java/org/booklore/service/reader/EpubReaderService.java
…rService Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
# Conflicts: # booklore-api/src/main/java/org/booklore/controller/MetadataController.java # booklore-api/src/main/java/org/booklore/service/ShelfService.java # booklore-api/src/main/java/org/booklore/service/book/BookReviewService.java # booklore-api/src/main/java/org/booklore/service/book/BookService.java # booklore-api/src/main/java/org/booklore/service/opds/OpdsBookService.java # booklore-api/src/main/java/org/booklore/service/opds/OpdsUserV2Service.java # booklore-api/src/test/java/org/booklore/controller/MetadataControllerTest.java # booklore-api/src/test/java/org/booklore/service/library/LibraryProcessingServiceRegressionTest.java
…improve metadata retrieval Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…amline user permission retrieval Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…ds for improved data retrieval Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…ove test clarity Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
# Conflicts: # booklore-api/src/main/java/org/booklore/repository/BookRepository.java # booklore-api/src/main/java/org/booklore/service/ReadingSessionService.java # booklore-api/src/main/java/org/booklore/service/book/BookService.java # booklore-api/src/main/java/org/booklore/service/opds/OpdsBookService.java # booklore-api/src/main/java/org/booklore/service/reader/AudioMetadataService.java # booklore-api/src/main/java/org/booklore/service/reader/EpubReaderService.java # booklore-api/src/main/java/org/booklore/service/upload/FileUploadService.java # booklore-api/src/test/java/org/booklore/service/library/LibraryProcessingServiceRegressionTest.java # booklore-api/src/test/java/org/booklore/service/library/LibraryProcessingServiceTest.java
# Conflicts: # booklore-api/src/main/java/org/booklore/config/security/filter/AbstractQueryParameterJwtFilter.java # booklore-api/src/main/java/org/booklore/config/security/filter/AudiobookStreamingJwtFilter.java # booklore-api/src/main/java/org/booklore/config/security/filter/DualJwtAuthenticationFilter.java # booklore-api/src/main/java/org/booklore/config/security/filter/EpubStreamingJwtFilter.java # booklore-api/src/main/java/org/booklore/config/security/filter/JwtAuthenticationFilter.java # booklore-api/src/main/java/org/booklore/controller/MetadataController.java # booklore-api/src/main/java/org/booklore/service/library/LibraryService.java # booklore-api/src/main/java/org/booklore/service/metadata/BookCoverService.java # booklore-api/src/main/java/org/booklore/service/metadata/BookMetadataUpdater.java # booklore-api/src/main/java/org/booklore/service/reader/AudioMetadataService.java # booklore-api/src/test/java/org/booklore/controller/MetadataControllerTest.java # booklore-api/src/test/java/org/booklore/service/metadata/BookCoverServiceTest.java # booklore-api/src/test/java/org/booklore/service/metadata/BookMetadataServiceConcurrencyTest.java # booklore-api/src/test/java/org/booklore/service/metadata/BookMetadataServiceTest.java
…efactor related methods
…oved query efficiency and readability
# Conflicts: # booklore-api/src/main/java/org/booklore/service/reader/AudioMetadataService.java
This comment was marked as spam.
This comment was marked as spam.
* chore(ui): drop support animation preferences * chore(ui): drop unused github support dialog * chore(ui): drop github support dialog
- stop publishing unit test results directly from the pull_request test jobs\n- upload the GitHub event payload from CI so a follow-up workflow can reuse the original PR context\n- add a workflow_run publisher that downloads backend/frontend test artifacts and posts the check runs and PR comments with the permissions Dependabot PRs require\n- keep the reusable test suite focused on executing tests and producing artifacts without failing on comment permissions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
NOTE: this is almost straight from my PR to former BL upstream. Most of the works has been done in January, original PR submitted in February, and since then I have been running these changes on my private fork.
The port to grimmory, is strictly WIP. Better PR message is to after follow this.
Linked Issue: Fixes #
🏷️ Type of Change
🔧 Changes
🧪 Testing (MANDATORY)
Manual testing steps you performed:
Regression testing:
Edge cases covered:
Test output:
Backend test output (
./gradlew test)Frontend test output (
ng test)📸 Screen Recording / Screenshots (MANDATORY)
✅ Pre-Submission Checklist
develop(merge conflicts resolved)🤖 AI-Assisted Contributions
TODOs, or unused scaffolding left behind by AI💬 Additional Context (optional)
Summary by CodeRabbit
Performance Improvements
Reading Progress
Audio Metadata
Chores