Skip to content

fix(i18n): changed hardcoded translation strings, translation reactivity#107

Draft
judelgadoc wants to merge 3 commits intogrimmory-tools:developfrom
judelgadoc:fix/translation-problems
Draft

fix(i18n): changed hardcoded translation strings, translation reactivity#107
judelgadoc wants to merge 3 commits intogrimmory-tools:developfrom
judelgadoc:fix/translation-problems

Conversation

@judelgadoc
Copy link
Contributor

fix(i18n): changed hardcoded translation strings, translation reactivity

Description

First PR in a long time, don't want to mess it up so draft PR while I look for more instances of the bugs in other parts of the UI and make sure it's okay 😅

fix(stats): changed language display names in LibraryStats/LanguageChart
fix(shared): added missing translation strings to the json files
fix(i18n): translation reactivity in parts of the ui

Linked Issue: Fixes #103

Changes

LanguageChart now uses Intl.DisplayNames
EntityType keys changed for correct translation (was hardcoded to english in the struct)

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 21, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6217e5ca-240a-4136-ab72-b1bfd0c8868e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable sequence diagrams in the walkthrough.

Disable the reviews.sequence_diagrams setting to disable sequence diagrams in the walkthrough.

@balazs-szucs
Copy link
Member

First PR in a long time, don't want to mess it up so draft PR while I look for more instances of the bugs in other parts of the UI and make sure it's okay 😅

hi, no pressure. This is actual something that is also rather high priority but I'm juggling other things. Mainly Hibernate/epub4j so never had time to start it

This is really welcome, many thanks for raising!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Translation problems

2 participants