fix(i18n): changed hardcoded translation strings, translation reactivity#107
fix(i18n): changed hardcoded translation strings, translation reactivity#107judelgadoc wants to merge 3 commits intogrimmory-tools:developfrom
Conversation
whole icon-picker and book browser's title
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment Tip You can disable sequence diagrams in the walkthrough.Disable the |
hi, no pressure. This is actual something that is also rather high priority but I'm juggling other things. Mainly Hibernate/epub4j so never had time to start it This is really welcome, many thanks for raising! |
fix(i18n): changed hardcoded translation strings, translation reactivity
Description
First PR in a long time, don't want to mess it up so draft PR while I look for more instances of the bugs in other parts of the UI and make sure it's okay 😅
fix(stats): changed language display names in LibraryStats/LanguageChart
fix(shared): added missing translation strings to the json files
fix(i18n): translation reactivity in parts of the ui
Linked Issue: Fixes #103
Changes
LanguageChart now uses Intl.DisplayNames
EntityType keys changed for correct translation (was hardcoded to english in the struct)