-
Notifications
You must be signed in to change notification settings - Fork 9
Add support for large structures to mstore #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lukaswittmann
merged 26 commits into
grimme-lab:main
from
lukaswittmann:large-structures
Dec 23, 2025
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
dea3add
Added larger structures for testing timings and robustness
lukaswittmann 20911e4
Woops, i should rename everything
lukaswittmann 04f5e19
Revert "Woops, i should rename everything"
lukaswittmann 7d36469
Woops, i should rename everything
lukaswittmann d280020
Fix cmake build
lukaswittmann 5ef801e
Possible gcc ubuntu-latest fix
lukaswittmann c1485dc
Added mindless molecule with atoms Fr to Lr
lukaswittmann 3ff751d
Updated intel job to use ubuntu-latest and bumped actions to supporte…
lukaswittmann 1587bc3
Possible fix for the intel build still sticking to ifort
lukaswittmann a344dbf
Possible fix for the intel CI
lukaswittmann 9defbf3
Possible fix for intel build (local build working)
lukaswittmann 0b7cc59
meson: detect and link libunwind for Fortran traceback
lukaswittmann 3eafae4
CI: install libunwind-dev on intel Ubuntu runners
lukaswittmann 6d97188
meson: only probe libunwind when a C compiler is present
lukaswittmann c0559ba
Revert "CI: install libunwind-dev on intel Ubuntu runners"
lukaswittmann 0d4161c
Revert "meson: detect and link libunwind for Fortran traceback"
lukaswittmann 6bfde10
CI: update MSYS2 packages on Windows runner (enable update)
lukaswittmann b32ce39
Added systematic alanine and amylose chains. Removed old large struct…
lukaswittmann 2031247
Fix trailing whitespace
lukaswittmann 28616b8
Fix typo
lukaswittmann 2bb53b3
Fix cmake build
lukaswittmann af29241
Switch macos runner
lukaswittmann 7a7fe5b
gcc bin to path, set env variables, removed symlinks, export gh env
lukaswittmann 7355ee8
set env vars
lukaswittmann 3715d12
use gcc13
lukaswittmann e810455
update meson version
lukaswittmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,11 +27,16 @@ jobs: | |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, macos-13] | ||
| os: [ubuntu-latest, macos-15-intel] | ||
| include: | ||
| - os: ubuntu-latest | ||
| gcc_v: 10 | ||
| - os: macos-15-intel | ||
| gcc_v: 13 | ||
|
|
||
| env: | ||
| FC: gfortran | ||
| GCC_V: 10 | ||
| GCC_V: ${{ matrix.gcc_v }} | ||
| PYTHON_V: 3.8 | ||
|
|
||
| steps: | ||
|
|
@@ -47,24 +52,35 @@ jobs: | |
| if: contains(matrix.os, 'macos') | ||
| run: | | ||
| brew install gcc@${{ env.GCC_V }} | ||
| ln -s /usr/local/bin/gfortran-${{ env.GCC_V }} /usr/local/bin/gfortran | ||
| ln -s /usr/local/bin/gcc-${{ env.GCC_V }} /usr/local/bin/gcc | ||
| ln -s /usr/local/bin/g++-${{ env.GCC_V }} /usr/local/bin/g++ | ||
| which gfortran | ||
| echo "$(brew --prefix gcc@${{ env.GCC_V }})/bin" >> $GITHUB_PATH | ||
| echo "FC=$(brew --prefix gcc@${{ env.GCC_V }})/bin/gfortran-${{ env.GCC_V }}" >> $GITHUB_ENV | ||
| echo "CC=$(brew --prefix gcc@${{ env.GCC_V }})/bin/gcc-${{ env.GCC_V }}" >> $GITHUB_ENV | ||
| echo "CXX=$(brew --prefix gcc@${{ env.GCC_V }})/bin/g++-${{ env.GCC_V }}" >> $GITHUB_ENV | ||
|
|
||
| - name: Install GCC (Linux) | ||
| if: contains(matrix.os, 'ubuntu') | ||
| run: | | ||
| sudo update-alternatives \ | ||
| --install /usr/bin/gcc gcc /usr/bin/gcc-${GCC_V} 100 \ | ||
| --slave /usr/bin/gfortran gfortran /usr/bin/gfortran-${GCC_V} \ | ||
| --slave /usr/bin/gcov gcov /usr/bin/gcov-${GCC_V} | ||
| if [[ -x "/usr/bin/gcc-${GCC_V}" && -x "/usr/bin/gfortran-${GCC_V}" ]]; then | ||
| echo "Using GCC ${GCC_V} via update-alternatives" | ||
| sudo update-alternatives \ | ||
| --install /usr/bin/gcc gcc /usr/bin/gcc-${GCC_V} 100 \ | ||
| --slave /usr/bin/gfortran gfortran /usr/bin/gfortran-${GCC_V} \ | ||
| --slave /usr/bin/gcov gcov /usr/bin/gcov-${GCC_V} | ||
| else | ||
| echo "GCC ${GCC_V} not found; using default system compilers" | ||
| gcc --version | ||
| gfortran --version | ||
| fi | ||
|
|
||
| - name: Install meson/cmake | ||
| run: pip3 install meson==0.57.2 ninja cmake | ||
| run: pip3 install meson==1.4.1 ninja cmake | ||
|
|
||
| - name: Configure meson build | ||
| run: meson setup ${{ env.M_BUILD_DIR }} | ||
| run: | | ||
| export FC="${FC:-gfortran}" | ||
| export CC="${CC:-gcc}" | ||
| export CXX="${CXX:-g++}" | ||
| meson setup ${{ env.M_BUILD_DIR }} | ||
|
|
||
| - name: Build library (meson) | ||
| run: meson compile -C ${{ env.M_BUILD_DIR }} | ||
|
|
@@ -103,7 +119,7 @@ jobs: | |
| uses: msys2/setup-msys2@v2 | ||
| with: | ||
| msystem: ${{ matrix.msystem }} | ||
| update: false | ||
| update: true | ||
| install: >- | ||
| git | ||
| mingw-w64-${{ matrix.arch }}-gcc-fortran | ||
|
|
@@ -147,17 +163,17 @@ jobs: | |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-20.04] | ||
| os: [ubuntu-latest] | ||
|
|
||
| env: | ||
| FC: ifort | ||
| FC: ifx | ||
| OMP_NUM_THREADS: 2,1 | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v2 | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - uses: actions/setup-python@v1 | ||
| - uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: '3.x' | ||
|
|
||
|
|
@@ -171,28 +187,26 @@ jobs: | |
|
|
||
| - name: Install Intel oneAPI compiler | ||
| run: | | ||
| sudo apt-get install intel-oneapi-compiler-fortran | ||
| source /opt/intel/oneapi/setvars.sh | ||
| printenv >> $GITHUB_ENV | ||
| sudo apt-get install -y intel-oneapi-compiler-fortran | ||
|
|
||
| - name: Install meson/cmake | ||
| run: pip3 install meson==0.56.2 ninja cmake | ||
| run: pip3 install meson==1.4.1 ninja cmake | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If it doesn't break we can also update to the current meson version (about 1.8.x) |
||
|
|
||
| - name: Configure meson build | ||
| run: meson setup ${{ env.M_BUILD_DIR }} | ||
| run: . /opt/intel/oneapi/setvars.sh && meson setup ${{ env.M_BUILD_DIR }} | ||
|
|
||
| - name: Build library (meson) | ||
| run: meson compile -C ${{ env.M_BUILD_DIR }} | ||
| run: . /opt/intel/oneapi/setvars.sh && meson compile -C ${{ env.M_BUILD_DIR }} | ||
|
|
||
| - name: Run unit tests (meson) | ||
| run: meson test -C ${{ env.M_BUILD_DIR }} --print-errorlogs --no-rebuild | ||
| run: . /opt/intel/oneapi/setvars.sh && meson test -C ${{ env.M_BUILD_DIR }} --print-errorlogs --no-rebuild | ||
|
|
||
| - name: Configure cmake build | ||
| run: cmake -B ${{ env.C_BUILD_DIR }} -G Ninja | ||
| run: . /opt/intel/oneapi/setvars.sh && cmake -B ${{ env.C_BUILD_DIR }} -G Ninja | ||
|
|
||
| - name: Build library (CMake) | ||
| run: cmake --build ${{ env.C_BUILD_DIR }} | ||
| run: . /opt/intel/oneapi/setvars.sh && cmake --build ${{ env.C_BUILD_DIR }} | ||
|
|
||
| - name: Run unit tests (CTest) | ||
| run: ctest | ||
| run: . /opt/intel/oneapi/setvars.sh && ctest | ||
| working-directory: ${{ env.C_BUILD_DIR }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the
setup-fortranaction to take care of all the compiler setup (see here)