Open
Conversation
Signed-off-by: Marcel Müller <marcel.mueller@thch.uni-bonn.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase of test threshold
On
macos-14on M3 Pro chip on my personal laptop, usinggcc-14.2.0.1,dft/minisfails due to a too large difference in test results:I'd say 10e-14 is still in the range of acceptable and might have very much underlying reasons, which is why I'd just increase the threshold. Effectively, it would be (on my machine) at:
2.2204460492503131E-013The same behavior is observed in the formula tests of https://github.com/grimme-lab/homebrew-qc, specifically under:
https://github.com/grimme-lab/homebrew-qc/actions/runs/11914547724/job/33210586002
In the unit tests, this is not the case, which puzzles me a bit...