Merged
Conversation
The toggle to enable/disable host access on the landing page doesn't make sense - this security config should only be controlled on the host itself (via CLI flags like --host-access), not remotely through the web interface. - Remove updateHostAccess endpoint from backend router - Remove updateHostAccess API method from frontend - Make HostSection display-only, showing how to enable via CLI flag
gricha
force-pushed
the
remove-host-access-toggle
branch
from
075db92 to
0a27f4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--host-access), not remotely through the web interfaceChanges
updateHostAccessendpoint from routerupdateHostAccessAPI method and toggle mutationHostSectionto be display-only, showing CLI instructions when disabled