Consolidate chat handlers with base class pattern#33
Merged
Conversation
Refactor to eliminate ~95% code duplication between container and host chat handlers by extracting shared logic into abstract base classes: - Create src/chat/types.ts with shared interfaces (ChatMessage, ClaudeStreamMessage, OpencodeStreamEvent, SpawnConfig, etc.) - Create src/chat/base-claude-session.ts with shared Claude Code logic (buffer processing, stream message handling, interrupt, setModel) - Create src/chat/base-opencode-session.ts with shared OpenCode logic (buffer processing, stream event handling, interrupt, setModel) - Refactor ChatSession and HostChatSession to extend BaseClaudeSession - Refactor OpencodeSession and HostOpencodeSession to extend BaseOpencodeSession - Add DEFAULT_CLAUDE_MODEL constant to src/shared/constants.ts Each handler now only implements: - getSpawnConfig(): command and spawn options specific to container/host - getLogPrefix(): logging identifier - getNoOutputErrorMessage(): context-specific error message - loadHistory() (OpenCode only): history loading strategy This reduces code from ~850 lines across 4 files to ~250 lines in handlers plus ~350 lines in shared base classes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseClaudeSessionandBaseOpencodeSessionwith shared logicChanges
src/chat/types.tswith shared interfacessrc/chat/base-claude-session.tsfor Claude Code handlerssrc/chat/base-opencode-session.tsfor OpenCode handlersDEFAULT_CLAUDE_MODELconstantTest plan
🤖 Generated with Claude Code