Merged
Conversation
- Add @shared path alias in Vite and TypeScript configs to import from parent src/shared directory - Update web/src/lib/api.ts to import types from @shared/client-types - Replace web/src/lib/types.ts with simple re-export from @shared - Remove cp command from build:web script in package.json Web now imports types directly from src/shared/client-types.ts instead of using a build-time copy. This eliminates type drift between source and web builds. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update Sidebar.tsx, WorkspaceDetail.tsx, and WorkspaceList.tsx to import HOST_WORKSPACE_NAME directly from @shared/client-types instead of the now-removed @/lib/types path. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@sharedpath alias in Vite and TypeScript configssrc/shared/client-types.tsinstead of using a build-time copycp src/shared/client-types.ts web/src/lib/types.tscommand from build:webWhy
The previous approach copied
client-types.tstoweb/src/lib/types.tsat build time. This was fragile because:Changes
web/vite.config.ts: Add@sharedalias pointing to../src/sharedweb/tsconfig.app.json: Add@shared/*path and include../src/sharedweb/src/lib/api.ts: Import types from@shared/client-typesweb/src/lib/types.ts: Replace with single-line re-export from@shared/client-typespackage.json: Remove cp command from build:web scriptTest plan
bun run validatepasses all tests🤖 Generated with Claude Code