Conversation
- CONTAINER_PREFIX: Remove local definition in docker/index.ts, import from shared/constants.ts instead - HOST_WORKSPACE_NAME: Keep canonical definition in client-types.ts, remove from types.ts, update imports to use client-types.ts This eliminates duplication and ensures single source of truth for these constants. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONTAINER_PREFIX: Remove local definition indocker/index.ts, import fromshared/constants.tsinsteadHOST_WORKSPACE_NAME: Keep canonical definition inclient-types.ts, remove fromtypes.ts, update importsThis eliminates duplication and ensures single source of truth for these constants.
Changes
src/docker/index.ts: ImportCONTAINER_PREFIXfrom../shared/constantsinstead of local definitionsrc/shared/types.ts: RemoveHOST_WORKSPACE_NAMEconstantsrc/shared/client-types.ts: Keep as canonical location forHOST_WORKSPACE_NAMEHOST_WORKSPACE_NAMEfromclient-types.tsinstead oftypes.tsTest plan
bun run validatepasses all tests🤖 Generated with Claude Code