Closed
Conversation
- Sequential fetch waterfall in useEffect instead of parallel queries - Full lodash import instead of specific function - Array index as key - Inline style objects in map - window.location.reload() as refetch
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
209
to
-212
| }) | ||
| } | ||
|
|
||
| const handleRowClick = (ws: WorkspaceInfo) => { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Comment on lines
+190
to
+200
| setLoading(true) | ||
| try { | ||
| const workspaces = await api.listWorkspaces() | ||
| setWorkspaceData(workspaces) | ||
| const host = await api.getHostInfo() | ||
| setHostData(host) | ||
| } catch (e) { | ||
| setErr(e as Error) | ||
| } finally { | ||
| setLoading(false) | ||
| } |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| loadData() | ||
| }, []) | ||
|
|
||
| const refetch = () => window.location.reload() |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary