fix: workspace creation failing with misleading error#136
Merged
Conversation
Two issues fixed: 1. mapErrorToORPC was too generic - any error containing "not found" was converted to "Workspace not found", making "Workspace image not found" errors confusing. Now only matches actual workspace-not-found patterns. 2. ensureWorkspaceImage only checked for perry:latest locally, then tried to PULL the registry image even if it already existed. If pull failed (network/auth), it would error. Now checks if registry image exists locally before attempting pull.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mapErrorToORPCwas converting any error with "not found" to "Workspace not found" - made image errors confusingensureWorkspaceImagetried to pull registry image even when it existed locally - failed on network/auth issues