Skip to content

When executing make or run, never consider modules from dependencies as roots. #351

Merged
robinheghan merged 1 commit intomainfrom
push-xwwroxnzvkos
Sep 8, 2025
Merged

When executing make or run, never consider modules from dependencies as roots. #351
robinheghan merged 1 commit intomainfrom
push-xwwroxnzvkos

Conversation

@robinheghan
Copy link
Member

This prevents ambigious import errors when trying to make/run root modules that happens to clash with a module in a dependency.

…as a root module. This prevents ambigious import errors.
@robinheghan robinheghan requested a review from blaix September 6, 2025 10:00
@robinheghan robinheghan self-assigned this Sep 6, 2025
@robinheghan
Copy link
Member Author

Potential fix for #350

Copy link
Contributor

@blaix blaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Tested and confirmed it fixes #350

@robinheghan robinheghan merged commit 2115616 into main Sep 8, 2025
5 checks passed
@robinheghan robinheghan deleted the push-xwwroxnzvkos branch September 8, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants