feat: Add unittests for Chao in the gremlin chart #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefirstofthe300
force-pushed
the
PLATFORM-2196/unit-testing
branch
from
4b5855f to
2e4d3d4
Compare
thefirstofthe300
force-pushed
the
PLATFORM-2196/unit-testing
branch
from
2e4d3d4 to
dac2dc1
Compare
philgebhardt
reviewed
Feb 7, 2025
| */}} | ||
| {{- define "gremlin.validateValues" -}} | ||
| {{- $messages := list -}} | ||
| {{- $messages := append $messages (include "gremlin.validateValues.secret" .) -}} |
Contributor
There was a problem hiding this comment.
should we call this gremlin.validateValues.certificate instead?
Contributor
Author
There was a problem hiding this comment.
I don't think it matters one way or the other? I'd lean towards secret just because it's mainly about validating the managed secret inputs.
philgebhardt
reviewed
Feb 7, 2025
Co-authored-by: Phil Gebhardt <phil@gremlin.com>
philgebhardt
approved these changes
Feb 10, 2025
fred-gremlin
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help gain confidence that future refactors will not completely break the chart, we should add unit testing to catch problems before they're merged.