filter out carriage returns for readfile #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I agree that using readFile from Text is probably best. One potential difference though is the current use of lenientDecode: we don't want programs to crash from reading a file with an invalid UTF character. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to this pull request
yesodweb/shakespeare#113 referrring to https://gist.github.com/gbwey/6833805
This change to readfile will filter out carriage returns as does Data.Text.IO.readFile.
Avoids the situation in windows where you read a file/then write it back and it is different.
Is there a reason why we don't just use Data.Text.IO.readFile?
Thanks,
Grant