Skip to content

Conversation

@embeddDev
Copy link

No description provided.

@gregorychen3
Copy link
Owner

gregorychen3 commented Dec 31, 2022

Hello @embeddDev , thanks for your interest in this project! Skimming through the code change, it looks like you've added the following features:

  • OLED Temperature Display
  • systemd configs for the go binary and oled python service

OLED Temperature Display

This feature may be a bit redundant. The go binary already serves up a full UI for monitoring the temperature and configuring the PID control.

Part of this project's appeal is that installation is dead simple: just copy the compiled go binary to the raspi; no need to struggle with envs, PATH variable, python versions, or pip. But this OLED feature breaks this as it requires the startup of a separate python service. I'd prefer not to bring in python if it can be helped.

systemd configs

This is very useful! Can you add it to the existing README.md under Raspi Setup as an optional 5th step? Also, I think you can just paste the systemd config into the readme itself, no need to add a new file to the repo.

Let me know what you think. And again thanks for your interest and contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants