Skip to content

Feature/pyproject#3

Open
gregorjerse wants to merge 3 commits intomasterfrom
feature/pyproject
Open

Feature/pyproject#3
gregorjerse wants to merge 3 commits intomasterfrom
feature/pyproject

Conversation

@gregorjerse
Copy link
Owner

No description provided.

@gregorjerse gregorjerse requested a review from Copilot November 14, 2025 18:51
@gregorjerse gregorjerse self-assigned this Nov 14, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project from a traditional setup.py and setup.cfg configuration to a modern pyproject.toml standard, updating Python and dependency versions in the process.

Key changes:

  • Replaced setup.py and setup.cfg with pyproject.toml for package configuration
  • Updated Python requirement from 3.10 to 3.13-3.14 and upgraded Django from 4.1 to 5.2.8 along with other dependencies
  • Fixed module path references in Django settings to use qualified names (tests.urls, tests.wsgi.application)

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pyproject.toml New file defining project metadata, dependencies, and build configuration using modern Python packaging standards
setup.py Removed legacy setup script in favor of pyproject.toml
setup.cfg Removed legacy configuration file; linting/formatting configs moved or deprecated
src/reservations/about.py Removed metadata file as this information is now in pyproject.toml
tests/settings.py Updated module paths and simplified documentation comments
manage.py Fixed Django settings module path to use qualified name
README.rst Added installation and usage instructions for the project

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Usage
=====

The administration interface can be accessed at ``localhhost:8000/admin/``.
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'localhhost' to 'localhost'.

Suggested change
The administration interface can be accessed at ``localhhost:8000/admin/``.
The administration interface can be accessed at ``localhost:8000/admin/``.

Copilot uses AI. Check for mistakes.
5. Run the development server.
.. code-block:: bash

uv run manage.py runserver
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation in code block. The indentation should match the pattern used in other code blocks (lines 12-14, 20-22, etc.) where content is indented with spaces after the directive.

Suggested change
uv run manage.py runserver
uv run manage.py runserver

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant