(+): enabled ARC memory management.#1
Open
Panajev wants to merge 2 commits intogregharding:masterfrom
Open
Conversation
I used Cocos2D as an external static library to test this. Instructions on how to obtain the complete library package (CocosLib + CocosTools + Utilities), build it, and install it can be found here: https://github.com/Panajev/CocosLib#howto-install
Owner
|
hi Panajev, thanks for the update. I don't know anything about ARC yet so I'm not sure whether to merge the changes or not. Perhaps they could be conditionally compiled or something? |
Author
|
Hey, sorry for taking so long to answer back (btw, hoping CCRenderTexture behaves better now :)). Yes, conditional compilation is indeed possible. I'll review the changes I made and conditionally enable ARC. |
Brought back old funcgtionality when ARC is disabled.
Author
|
Now, it should be easier to merge in I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used Cocos2D as an external static library to test this.
Instructions on how to obtain the complete library package (CocosLib +
CocosTools + Utilities), build it, and install it can be found here:
https://github.com/Panajev/CocosLib#howto-install